NO-JIRA: Saner image aliases#80230
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (21)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (17)
WalkthroughThis PR renames versioned CI base-image keys across installer configs, replacing ChangesBase image reference unification
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift/installer/openshift-installer-main.yaml (1)
126-128:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: raw_steps reference removed base_images key.
Lines 126-128 were not updated when the base image keys were renamed. Line 127 references
from: ocp_4.22_base-rhel9, but that key no longer exists inbase_images(it was renamed toocp_base-rhel9at lines 38-41). This will cause the pipeline_image_cache_step to fail when ci-operator attempts to resolve the base image reference.Additionally, line 126 should use the
base-openstack-5-0repo URL to align with the"5.0"version inbase_images, consistent with the pattern applied in the 5.0 and 5.1 release configs.🔧 Proposed fix to align raw_steps with renamed base images
raw_steps: - pipeline_image_cache_step: commands: | - curl http://base-openstack-4-22.ocp.svc/ > /etc/yum.repos.art/ci/base-openstack-4-22.repo - from: ocp_4.22_base-rhel9 + curl http://base-openstack-5-0.ocp.svc/ > /etc/yum.repos.art/ci/base-openstack-5-0.repo + from: ocp_base-rhel9 to: openstack-base🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/installer/openshift-installer-main.yaml` around lines 126 - 128, Update the raw_steps to reference the renamed base_images keys and correct repo URL: replace the stale from: ocp_4.22_base-rhel9 with the current key ocp_base-rhel9 (the key renamed in base_images) and change the curl target from base-openstack-4-22.ocp.svc to base-openstack-5-0.ocp.svc so the repo matches the "5.0" entry in base_images; ensure the pipeline_image_cache_step now points to ocp_base-rhel9 and the repo URL base-openstack-5-0 to avoid resolution failures.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@ci-operator/config/openshift/installer/openshift-installer-main.yaml`:
- Around line 126-128: Update the raw_steps to reference the renamed base_images
keys and correct repo URL: replace the stale from: ocp_4.22_base-rhel9 with the
current key ocp_base-rhel9 (the key renamed in base_images) and change the curl
target from base-openstack-4-22.ocp.svc to base-openstack-5-0.ocp.svc so the
repo matches the "5.0" entry in base_images; ensure the
pipeline_image_cache_step now points to ocp_base-rhel9 and the repo URL
base-openstack-5-0 to avoid resolution failures.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: bc13f853-036f-428c-864e-e04820c8658b
📒 Files selected for processing (21)
ci-operator/config/openshift/installer/openshift-installer-main.yamlci-operator/config/openshift/installer/openshift-installer-release-4.10.yamlci-operator/config/openshift/installer/openshift-installer-release-4.11.yamlci-operator/config/openshift/installer/openshift-installer-release-4.12.yamlci-operator/config/openshift/installer/openshift-installer-release-4.13.yamlci-operator/config/openshift/installer/openshift-installer-release-4.14.yamlci-operator/config/openshift/installer/openshift-installer-release-4.15.yamlci-operator/config/openshift/installer/openshift-installer-release-4.15__altinfra.yamlci-operator/config/openshift/installer/openshift-installer-release-4.16.yamlci-operator/config/openshift/installer/openshift-installer-release-4.16__altinfra.yamlci-operator/config/openshift/installer/openshift-installer-release-4.17.yamlci-operator/config/openshift/installer/openshift-installer-release-4.17__altinfra.yamlci-operator/config/openshift/installer/openshift-installer-release-4.18.yamlci-operator/config/openshift/installer/openshift-installer-release-4.18__altinfra.yamlci-operator/config/openshift/installer/openshift-installer-release-4.19.yamlci-operator/config/openshift/installer/openshift-installer-release-4.20.yamlci-operator/config/openshift/installer/openshift-installer-release-4.21.yamlci-operator/config/openshift/installer/openshift-installer-release-4.22.yamlci-operator/config/openshift/installer/openshift-installer-release-4.23.yamlci-operator/config/openshift/installer/openshift-installer-release-5.0.yamlci-operator/config/openshift/installer/openshift-installer-release-5.1.yaml
Remove irrelevant version identifiers from these image which were giving the impression that we were dealing with older images than we actually are. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Looks like the bot reverted this in commit bf0239b. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
installer-image-sanity
branch
from
470988f to
0eb64cb
Compare
|
[REHEARSALNOTIFIER]
A total of 1672 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-installer-release-4.23-e2e-openstack-ovn pull-ci-openshift-installer-release-5.0-e2e-openstack-ovn |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
4.23 failure is due to openshift/installer#10573 |
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Remove irrelevant version identifiers from these image which were giving the impression that we were dealing with older images than we actually are.
Summary by CodeRabbit
This PR standardizes image aliases in the OpenShift installer CI configuration so the CI manifests no longer carry misleading, hard-coded older version numbers in their image keys. It affects the ci-operator configs for the openshift/installer repo (files under ci-operator/config/openshift/installer/) across release branches from 4.10 through 5.1.
What changed in practice:
Impact: