AGENT-1534: Decrease master memory for agent HA iso-no-registry job#80228
AGENT-1534: Decrease master memory for agent HA iso-no-registry job#80228bfournie wants to merge 1 commit into
Conversation
|
@bfournie: This pull request references AGENT-1534 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis pull request adds a single configuration parameter ChangesHA Dualstack ISO Test Configuration
Possibly related PRs
Suggested labels
Suggested reviewers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Line 2173: The file shows MASTER_VCPU=15 only in the
e2e-agent-ha-dualstack-iso-no-registry-techpreview job; inspect the sibling jobs
e2e-agent-ha5-dualstack-iso-no-registry-techpreview and
e2e-agent-ha-dualstack-conformance and either (A) confirm the 15 setting is
intentionally only for e2e-agent-ha-dualstack-iso-no-registry-techpreview and
document that decision, or (B) make them consistent by adding MASTER_VCPU=15 (or
change all three to MASTER_VCPU=8 if the two-node-fencing value is the intended
mitigation) inside those job definitions so the HA dualstack agent jobs share
the same MASTER_VCPU behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 495c91c1-32d3-4667-803f-12f3210d0387
📒 Files selected for processing (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Increase the master VCPU to resolve the 'soft lockup' errors.
cd32192 to
274d0bf
Compare
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Decrease the master memory for the HA-dualstack test to resolve the 'soft lockup' errors. This makes the master memory the same as the HA5 configuration.
Summary by CodeRabbit
This PR increases the CPU resources allocated to master nodes in the OpenShift 5.0 agent-based installation CI test pipeline. Specifically, it adds
MASTER_VCPU=15to theDEVSCRIPTS_CONFIGenvironment variable for thee2e-agent-ha-dualstack-iso-no-registry-techpreviewjob, which is a nightly test running every 8 hours on bare metal infrastructure (equinix-ocp-metal cluster).Practical impact: This configuration change provides additional CPU resources to master nodes during agent-based HA deployment testing with ISO provisioning, addressing reported "soft lockup" errors that were occurring during test execution. The test provisions an HA cluster configuration with dual-stack networking and uses ISO-based boot without a local registry—a resource-intensive scenario that benefits from the increased CPU allocation.
Change scope: Single modification to the OpenShift 5.0 nightly test configuration file (+1 line).