ROSAENG-8193 | task: Migrate cs-rosa-hcp-ad-integration-main

[davidleerh]

Summary by CodeRabbit

This PR migrates the cs-rosa-hcp-ad-integration-main job to a dedicated CI configuration file in the OpenShift CI infrastructure. Specifically, it creates a new configuration file for the OpenShift Online ROSA e2e testing pipeline that defines multiple scheduled integration tests for ROSA HCP (Hosted Control Plane) scenarios.

Changes:

• New file: ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml (81 lines)

What this affects:
The PR adds CI job definitions for the openshift-online/rosa-e2e repository that run daily integration tests for ROSA HCP deployments. The configuration includes:

• Four scheduled periodic jobs running at 8 AM UTC daily:
  • AD (Active Directory) integration test
  • AutoNode integration test
  • Backup/Restore integration test
  • Control Plane upgrade integration test
• Each job uses the nested-podman capability and runs the rosa-e2e-ocm-fvt test with a 4-hour timeout against the OCM integration environment

This migration consolidates ROSA HCP integration test configurations into a dedicated CI operator configuration file, improving the organization and manageability of ROSA e2e testing infrastructure.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6c8a82f6-6796-4996-b254-a5966f963ab7

📥 Commits

Reviewing files that changed from the base of the PR and between 95adbef and e0e3155.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml

---

Walkthrough

A new periodic CI test job is added to the OpenShift Online ROSA e2e configuration. The job ocm-fvt-periodic-cs-rosa-hcp-ad-integration-main runs daily at 8 AM UTC, uses nested-podman capability, sets OCM environment variables, and executes the rosa-e2e-ocm-fvt test with a 4-hour timeout.

Changes

ROSA HCP AD Integration Test Schedule

Layer / File(s)	Summary
Periodic ROSA HCP AD integration test job configuration ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml	A new test entry scheduled to run daily at 8 AM UTC with environment variables for HCP AD integration testing, nested-podman capability requirement, and a 4-hour timeout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• openshift/release#80159: Updates timeout values for ROSA HCP periodic jobs in the same configuration file from 3h0m0s to 4h0m0s, indicating coordinated adjustments to HCP integration test execution time.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

• jfrazierRedHat
• tiwillia

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: migrating a scheduled test job (cs-rosa-hcp-ad-integration-main) in the CI operator configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies CI operator YAML configuration files, not Ginkgo test code. No test titles (It(), Describe(), Context(), etc.) were added or modified.
Test Structure And Quality	✅ Passed	PR only modifies CI operator YAML configuration file for scheduling integration tests; no Ginkgo test code present or modified. Custom check not applicable to infrastructure/configuration changes.
Microshift Test Compatibility	✅ Passed	PR adds CI configuration and test step registry files only, not new Ginkgo e2e tests. Check applies only to new Ginkgo tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR adds CI configuration for the ROSA e2e test suite, not new Ginkgo e2e tests. The changes reference existing test steps (rosa-e2e-ocm-fvt) that execute via bash scripts, not Ginkgo test code.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only CI test configuration without deployment manifests, operator code, or any scheduling constraints (affinity, tolerations, node selectors). Check not applicable.
Ote Binary Stdout Contract	✅ Passed	PR adds only CI configuration and shell script test steps, not OTE binaries. OTE Binary Stdout Contract check is inapplicable to non-Go binary code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds CI configuration YAML only, not Ginkgo test code. The referenced test runs in a container, not inline Ginkgo tests subject to the IPv6 check.
No-Weak-Crypto	✅ Passed	PR contains only CI configuration YAML and utility scripts with no weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) or custom crypto implementations.
Container-Privileges	✅ Passed	Modified YAML configuration contains no privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root access).
No-Sensitive-Data-In-Logs	✅ Passed	PR adds YAML test config with environment variable references (job names, paths) but no embedded passwords, tokens, API keys, PII, or sensitive data in logs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidleerh
Once this PR has been reviewed and has the lgtm label, please assign tiwillia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-online/rosa-e2e/OWNERS
• ci-operator/jobs/openshift-online/rosa-e2e/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@davidleerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-main	N/A	periodic	Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[davidleerh]

/pj-rehearse ack

[openshift-merge-bot]

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davidleerh]

/ok-to-test

[davidleerh]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-main

[openshift-merge-bot]

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davidleerh]

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-ad-integration-main

[openshift-merge-bot]

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@davidleerh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.