OCPBUGS-62118: fix TLS client cert rotation when no CA is configured

[machine424]

Make sure it doesn't panic AND doesn't perma-fail.

Point prometheus/common to a patched version that
contains prometheus/common#908

Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.

[openshift-ci-robot]

@machine424: This pull request references Jira Issue OCPBUGS-62118, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Make sure it doesn't panic AND doesn't perma-fail.

Point prometheus/common to a patched version that
contains prometheus/common#908

Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7cd62f6e-4d99-446b-8b1a-568e86171dde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[machine424]

--- BEFORE FIX (unpatched prometheus/common v0.67.4) ---

=== RUN   TestClientTLSCertRotationWithoutCAFile
=== PAUSE TestClientTLSCertRotationWithoutCAFile
=== CONT  TestClientTLSCertRotationWithoutCAFile
    reload_test.go:194: time=2026-05-20T11:31:41.280+02:00 level=INFO source=main.go:1681 msg="updated GOGC" old=100 new=75
    reload_test.go:194: time=2026-05-20T11:31:41.281+02:00 level=INFO source=main.go:747 msg="Leaving GOMAXPROCS=12: CPU quota undefined" component=automaxprocs
    reload_test.go:194: time=2026-05-20T11:31:41.281+02:00 level=INFO source=memlimit.go:198 msg="GOMEMLIMIT is updated" component=automemlimit package=github.com/KimMachineGun/automemlimit/memlimit GOMEMLIMIT=30923764531 previous=9223372036854775807
    reload_test.go:194: time=2026-05-20T11:31:41.281+02:00 level=INFO source=main.go:854 msg="Starting Prometheus Server" mode=server version="(version=, branch=, revision=unknown)"
    reload_test.go:194: time=2026-05-20T11:31:41.281+02:00 level=INFO source=main.go:859 msg="operational information" build_context="(go=go1.25.0, platform=darwin/arm64, user=, date=, tags=builtinassets)" host_details=(darwin) fd_limits="(soft=122880, hard=unlimited)" vm_limits="(soft=unlimited, hard=unlimited)"
    reload_test.go:194: time=2026-05-20T11:31:41.347+02:00 level=INFO source=web.go:710 msg="Start listening for connections" component=web address=0.0.0.0:61518
    reload_test.go:194: time=2026-05-20T11:31:41.348+02:00 level=INFO source=main.go:1413 msg="Starting TSDB ..."
    reload_test.go:194: time=2026-05-20T11:31:41.349+02:00 level=INFO source=tls_config.go:354 msg="Listening on" component=web address=[::]:61518
    reload_test.go:194: time=2026-05-20T11:31:41.349+02:00 level=INFO source=tls_config.go:357 msg="TLS is disabled." component=web http2=false address=[::]:61518
    reload_test.go:194: time=2026-05-20T11:31:41.351+02:00 level=INFO source=head.go:698 msg="Replaying on-disk memory mappable chunks if any" component=tsdb
    reload_test.go:194: time=2026-05-20T11:31:41.351+02:00 level=INFO source=head.go:784 msg="On-disk memory mappable chunks replay completed" component=tsdb duration=14.625µs
    reload_test.go:194: time=2026-05-20T11:31:41.351+02:00 level=INFO source=head.go:792 msg="Replaying WAL, this may take a while" component=tsdb
    reload_test.go:194: time=2026-05-20T11:31:41.352+02:00 level=INFO source=head.go:865 msg="WAL segment loaded" component=tsdb segment=0 maxSegment=0 duration=443.375µs
    reload_test.go:194: time=2026-05-20T11:31:41.352+02:00 level=INFO source=head.go:902 msg="WAL replay completed" component=tsdb checkpoint_replay_duration=176.541µs wal_replay_duration=462.875µs wbl_replay_duration=0s chunk_snapshot_load_duration=0s mmap_chunk_replay_duration=14.625µs total_replay_duration=669.541µs
    reload_test.go:194: time=2026-05-20T11:31:41.353+02:00 level=INFO source=main.go:1434 msg="filesystem information" fs_type=1a
    reload_test.go:194: time=2026-05-20T11:31:41.353+02:00 level=INFO source=main.go:1437 msg="TSDB started"
    reload_test.go:194: time=2026-05-20T11:31:41.353+02:00 level=INFO source=main.go:1635 msg="Loading configuration file" filename=/var/folders/pl/4zxvwhbd0q5bkw9vxnk08swm0000gn/T/TestClientTLSCertRotationWithoutCAFile2268381937/001/prometheus.yml
    reload_test.go:194: time=2026-05-20T11:31:41.353+02:00 level=INFO source=main.go:1051 msg="TSDB retention updated" duration=15d size=0B percentage=0
    reload_test.go:194: time=2026-05-20T11:31:41.356+02:00 level=INFO source=main.go:1674 msg="Completed loading of configuration file" db_storage=20.5µs remote_storage=1.167µs web_handler=375ns query_engine=625ns scrape=2.807666ms scrape_sd=14.042µs notify=709ns notify_sd=542ns rules=916ns tracing=18.583µs filename=/var/folders/pl/4zxvwhbd0q5bkw9vxnk08swm0000gn/T/TestClientTLSCertRotationWithoutCAFile2268381937/001/prometheus.yml totalDuration=3.095584ms
    reload_test.go:194: time=2026-05-20T11:31:41.356+02:00 level=INFO source=main.go:1398 msg="Server is ready to receive web requests."
    reload_test.go:194: time=2026-05-20T11:31:41.356+02:00 level=INFO source=manager.go:209 msg="Starting rule manager..." component="rule manager"
    main_test.go:1152: 
        	Error Trace:	$PROMETHEUS_ROOT/cmd/prometheus/main_test.go:1152
        	Error:      	Condition never satisfied
        	Test:       	TestClientTLSCertRotationWithoutCAFile
        	Messages:   	scrape should keep working after cert rotation
--- FAIL: TestClientTLSCertRotationWithoutCAFile (10.51s)
FAIL
FAIL	github.com/prometheus/prometheus/cmd/prometheus	12.497s
FAIL

[machine424]

/jira refresh

[openshift-ci-robot]

@machine424: This pull request references Jira Issue OCPBUGS-62118, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (juzhao@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[machine424]

/verified by added test

[openshift-ci-robot]

@machine424: This PR has been marked as verified by added test.

Details

In response to this:

/verified by added test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danielmellado]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danielmellado,machine424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[machine424]

/retest-required

[openshift-ci]

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@machine424: Jira Issue Verification Checks: Jira Issue OCPBUGS-62118
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62118 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Make sure it doesn't panic AND doesn't perma-fail.

Point prometheus/common to a patched version that
contains prometheus/common#908

Add TestClientTLSCertRotationWithoutCAFile (backported from prometheus#18727) to verify the fix end-to-end.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-05-21-222828