Skip to content

STOR-3090: Add CSI storage test for pod delete after host umount of mounted volume - #31488

Open
radeore wants to merge 1 commit into
openshift:mainfrom
radeore:vol-umount-test
Open

STOR-3090: Add CSI storage test for pod delete after host umount of mounted volume#31488
radeore wants to merge 1 commit into
openshift:mainfrom
radeore:vol-umount-test

Conversation

@radeore

@radeore radeore commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add CSI suite OpenShift CSI extended - Pod delete after umount (migrated from openshift tests private OCP-66187).
  • Register via RegisterAlwaysOnCSISuites so it runs for all CSI drivers in openshift/csi.

Test plan

  • make openshift-tests
  • Dry-run: ./openshift-tests run openshift/csi --dry-run | grep 'Pod delete after umount'
  • Run against at least one driver (GCP PD)

Test run logs:

Ran 1 of 1 Specs in 26.038 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node",
    "lifecycle": "blocking",
    "duration": 26038,
    "startTime": "2026-08-05 20:46:00.551357 UTC",
    "endTime": "2026-08-05 20:46:26.589434 UTC",
    "result": "passed"

Summary by CodeRabbit

  • Tests
    • Added coverage for pod deletion when a CSI volume’s mount path is unexpectedly missing.
    • Expanded always-on CSI testing to include the new pod deletion scenario.
    • Added validation for dynamic volume provisioning, mounting, cleanup, and recovery behavior.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add CSI suite OpenShift CSI extended - Pod delete after umount (migrated from openshift tests private OCP-66187).
  • Register via RegisterAlwaysOnCSISuites so it runs for all CSI drivers in openshift/csi.

Test plan

  • make openshift-tests
  • Dry-run: ./openshift-tests run openshift/csi --dry-run | grep 'Pod delete after umount'
  • Run against at least one driver (GCP PD)

Test run logs:

Ran 1 of 1 Specs in 26.038 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node",
   "lifecycle": "blocking",
   "duration": 26038,
   "startTime": "2026-08-05 20:46:00.551357 UTC",
   "endTime": "2026-08-05 20:46:26.589434 UTC",
   "result": "passed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b8ae6089-bf1a-40ad-8e3d-c5590c578d93

📥 Commits

Reviewing files that changed from the base of the PR and between 8fcef61 and ccd7e34.

📒 Files selected for processing (2)
  • test/extended/storage/csi/csi.go
  • test/extended/storage/csi/pod_delete_after_umount.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from bertinatto and tsmetana August 5, 2026 21:00
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 5, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@radeore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn ccd7e34 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt

openshift-trt Bot commented Aug 6, 2026

Copy link
Copy Markdown

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: ccd7e34

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node" is a new test, and was only seen in one job.

New tests seen in this PR at sha: ccd7e34

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)] OpenShift CSI extended - Pod delete after umount should delete pod after volume directory was umounted on the node" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants