NO-ISSUE: Consider centos-10 stream for OKD clusters by pablintino · Pull Request #31487 · openshift/origin

pablintino · 2026-08-05T14:51:24Z

This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named okd should always match the only available stream, centos-10.

Summary by CodeRabbit

Bug Fixes
- Improved validation of standalone cluster operating system configurations.
- Correctly detects OKD clusters and verifies the required okd-scos job naming.
- Updated stream selection for OKD, RHEL CoreOS 9 and 10, and runtime-only scenarios.
- Upgrade validation now selects the appropriate RHEL version from the installation version, defaulting to RHEL 10 when needed.

openshift-merge-bot · 2026-08-05T14:51:26Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-08-05T14:51:27Z

@pablintino: This pull request explicitly references no jira issue.

Details

In response to this:

This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named okd should always match the only available stream, centos-10.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-05T14:51:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c6726188-feb5-4339-97d3-79e2a830eaed

📥 Commits

Reviewing files that changed from the base of the PR and between 96002ae and c30e4d8.

📒 Files selected for processing (1)

test/extended/ci/job_names.go

🚧 Files skipped from review as they are similar to previous changes (1)

test/extended/ci/job_names.go

Walkthrough

validateStandaloneNodeOS now validates OKD job-name markers and selects OS streams for OKD, RHCOS, Runc, upgrades, and default RHEL cases.

Changes

Standalone node OS validation

Layer / File(s)	Summary
OS validation and stream selection `test/extended/ci/job_names.go`	`validateStandaloneNodeOS` determines OKD from the desired cluster version, checks the full job name, and selects `centos-10`, RHCOS, Runc, upgrade, or default RHEL streams.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

openshift/origin#31481: Both PRs modify validateStandaloneNodeOS OS and stream selection logic.

Suggested labels: jira/valid-reference, ready-for-human-review

Suggested reviewers: sjenning, p0lyn0mial

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: selecting the centos-10 stream for OKD clusters.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes validation logic only. All Ginkgo titles in the changed file remain static literals, with no dynamic values or title edits.
Test Structure And Quality	✅ Passed	The diff only extends a read-only OS validation; it adds diagnostic Failf messages and no resource creation, cleanup need, Eventually, Consistently, or indefinite wait.
Microshift Test Compatibility	✅ Passed	The PR changes only existing helper logic; the Ginkgo declaration set is identical before and after, so no new e2e test requires MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The patch changes only validateStandaloneNodeOS in an existing job-name test; it adds no Ginkgo tests and makes no multi-node or HA assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only test/extended/ci/job_names.go; it adds OS stream validation and no deployment, operator, controller, manifest, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR only changes validation logic in validateStandaloneNodeOS, called from an It; it adds no fmt.Print, log, klog, or other stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes existing OS-stream validation only; it adds no Ginkgo test and introduces no IPv4 literals or external connectivity.
No-Weak-Crypto	✅ Passed	The PR changes only job-name and OS stream selection logic; added lines contain no weak-crypto primitives, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The patch changes only test/extended/ci/job_names.go; added lines contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only two fixed failure messages that include the derived CI job name; it does not log passwords, tokens, API keys, PII, session IDs, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-05T14:53:01Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablintino
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pablintino · 2026-08-05T14:56:38Z

/pipeline required
/test okd-scos-e2e-aws-ovn

openshift-merge-bot · 2026-08-05T14:56:43Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

coderabbitai · 2026-08-05T14:58:31Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

pablintino · 2026-08-05T14:58:48Z

/pipeline required
/test okd-scos-e2e-aws-ovn

openshift-merge-bot · 2026-08-05T14:58:52Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-trt · 2026-08-05T19:31:25Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 09a3843

Job Name	New Test Risk
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn	Medium - "Find all of the input images from origin/scos-5.0 and tag them into the stable stream" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn	Medium - "Find the input image origin_scos-5.0_tools and tag it into the pipeline" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 09a3843

"Find all of the input images from origin/scos-5.0 and tag them into the stable stream" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
"Find the input image origin_scos-5.0_tools and tag it into the pipeline" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

coderabbitai · 2026-08-06T11:27:43Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named *okd* should always match the only available stream, centos-10. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.eu>

openshift-ci · 2026-08-06T11:30:32Z

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	`09a3843`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-ovn-fips	`09a3843`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/okd-scos-e2e-aws-ovn	`09a3843`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pablintino · 2026-08-06T11:30:37Z

/pipeline required
/test okd-scos-e2e-aws-ovn

coderabbitai · 2026-08-06T11:30:38Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-08-06T11:30:41Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

neisw · 2026-08-06T11:53:05Z

 	clusterVersion, err := oc.AdminConfigClient().ConfigV1().ClusterVersions().Get(context.Background(), "version", metav1.GetOptions{})
 	o.Expect(err).NotTo(o.HaveOccurred(), "Error getting ClusterVersion version singleton")

+	isOKD := strings.Contains(clusterVersion.Status.Desired.Version, "okd-scos")


It feels like these checks don't really belong in validateStandaloneNodeOS

Could this isOKD logic / name check be above https://github.com/pablintino/origin/blob/c30e4d8664ac0dd3ebda399ef73d8ab911ec3c12/test/extended/ci/job_names.go#L179

Understand that will lead to a duplicate isOKD check as you need that for the targetStream as well.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2026

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 5, 2026

openshift-ci Bot requested review from p0lyn0mial and sjenning August 5, 2026 14:52

coderabbitai Bot approved these changes Aug 5, 2026

View reviewed changes

pablintino force-pushed the okd-job-names-test branch from 4ef1c9c to 09a3843 Compare August 5, 2026 14:58

pablintino force-pushed the okd-job-names-test branch from 09a3843 to 06e7ed3 Compare August 6, 2026 11:27

NO-ISSUE: Consider centos-10 stream for OKD clusters

c30e4d8

This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named *okd* should always match the only available stream, centos-10. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.eu>

pablintino force-pushed the okd-job-names-test branch from 06e7ed3 to c30e4d8 Compare August 6, 2026 11:30

neisw reviewed Aug 6, 2026

View reviewed changes

Uh oh!

Conversation

pablintino commented Aug 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

openshift-ci-robot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci Bot commented Aug 5, 2026

Uh oh!

pablintino commented Aug 5, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

pablintino commented Aug 5, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

openshift-trt Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

pablintino commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

neisw Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pablintino commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading