Skip to content

OCPNODE-4521: Use programmatic skip for single-node instead of test name tag #31486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschagrunert wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

OCPNODE-4521: Use programmatic skip for single-node instead of test name tag #31486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions test/extended/node/additional_storage_e2e.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,20 @@ import (

// Additional Storage E2E Tests - trigger MCO reconciliation (MCP rollouts)
// and run in the disruptive-longrunning suite.
//
// [Skipped:SingleReplicaTopology] - MCP rollouts don't work reliably on single-node
// clusters due to context deadline timeouts. The test creates a custom MCP which
// triggers node drains, but single-node cannot drain its only control plane node
// without bringing down the cluster.
var _ = g.Describe("[Skipped:Disconnected][Skipped:SingleReplicaTopology][apigroup:config.openshift.io][apigroup:machineconfiguration.openshift.io][Jira:Node/CRI-O][sig-node][Feature:AdditionalStorageSupport][OCPFeatureGate:AdditionalStorageConfig][Serial][Disruptive][Suite:openshift/disruptive-longrunning] Additional Storage E2E Tests", func() {
var _ = g.Describe("[Skipped:Disconnected][apigroup:config.openshift.io][apigroup:machineconfiguration.openshift.io][Jira:Node/CRI-O][sig-node][Feature:AdditionalStorageSupport][OCPFeatureGate:AdditionalStorageConfig][Serial][Disruptive][Suite:openshift/disruptive-longrunning] Additional Storage E2E Tests", func() {
defer g.GinkgoRecover()

var oc = exutil.NewCLI("additional-storage-e2e")

g.BeforeEach(func(ctx context.Context) {
SkipOnMicroShift(oc)

isSingleNode, err := exutil.IsSingleNode(ctx, oc.AdminConfigClient())
o.Expect(err).NotTo(o.HaveOccurred())
if isSingleNode {
g.Skip("MCP rollouts don't work reliably on single-node clusters")
}

EnsureNodesReady(ctx, oc)

enabled, reason := IsAdditionalStorageConfigEnabled(ctx, oc)
Expand Down