Skip to content

[release-4.19] OCPBUGS-104577: Backport node_e2e test migrations - #31484

Draft
Chandan9112 wants to merge 1 commit into
openshift:release-4.19from
Chandan9112:backport-node-e2e-4.19
Draft

[release-4.19] OCPBUGS-104577: Backport node_e2e test migrations#31484
Chandan9112 wants to merge 1 commit into
openshift:release-4.19from
Chandan9112:backport-node-e2e-4.19

Conversation

@Chandan9112

@Chandan9112 Chandan9112 commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Jira

OCPBUGS-104577

Related PRs

Release PR Status
4.22 #31306 Merged ✅
4.21 #31426 Merged ✅
4.20 #31430 Merged ✅

Changes (18 files)

New test files (test/extended/node/node_e2e/)

File Test Feature
container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)
image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)
image_registry_config.go Image registry allowedRegistries config image.config (GA)
initcontainer.go Init container restart behavior Core k8s
netns_cleanup.go Network namespace cleanup kubelet/CRI-O
node.go Kubelet log level, cgroupv2, devfuse Core node
pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)
probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

  • node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
  • node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)
  • imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

  • include.go — Added node/node_e2e blank import for test registration
  • go.mod — Moved k8s.io/kubelet from indirect to direct dependency
  • README.md — Documentation for running node tests
  • bindata.go — Regenerated to include new testdata
  • zz_generated.annotations.go — Regenerated test annotations

Testdata

  • testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

  1. Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).

  2. Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.

  3. Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

  • ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
  • Node cgroupv2, devfuse, kubelet logging are core node features
  • All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags
  • No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

@Chandan9112 @cursoragent
Backport node_e2e test migrations to release-4.19
00e5958 
Bulk backport of node_e2e test case migrations from main (OCP 5.0)
to release-4.19. These tests were previously backported to release-4.22
(PR openshift#31306, merged), release-4.21 (PR openshift#31426, merged), and release-4.20
(PR openshift#31430, merged).

Key adaptations for 4.19:
- Created minimal imagepolicy_helpers.go with MCP helper functions since
  test/extended/imagepolicy/ directory does not exist in 4.19
- Removed ote.Informing() decorators since openshift-tests-extension
  package is not available in 4.19
- Moved k8s.io/kubelet from indirect to direct dependency

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot added ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 5, 2026
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fb57e5f-2324-4ae9-a942-23b033856b3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan9112
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Chandan9112 Chandan9112 changed the title [release-4.19] Backport node_e2e test migrations [release-4.19] OCPBUGS-104577: Backport node_e2e test migrations Aug 5, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 5, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-104577, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-99782 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-99782 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Related PRs

Release PR Status
4.22 #31306 Merged ✅
4.21 #31426 Merged ✅
4.20 #31430 Merged ✅

Changes (18 files)

New test files (test/extended/node/node_e2e/)

File Test Feature
container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)
image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)
image_registry_config.go Image registry allowedRegistries config image.config (GA)
initcontainer.go Init container restart behavior Core k8s
netns_cleanup.go Network namespace cleanup kubelet/CRI-O
node.go Kubelet log level, cgroupv2, devfuse Core node
pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)
probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

  • node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
  • node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)
  • imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

  • include.go — Added node/node_e2e blank import for test registration
  • go.mod — Moved k8s.io/kubelet from indirect to direct dependency
  • README.md — Documentation for running node tests
  • bindata.go — Regenerated to include new testdata
  • zz_generated.annotations.go — Regenerated test annotations

Testdata

  • testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

  1. Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).

  2. Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.

  3. Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

  • ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
  • Node cgroupv2, devfuse, kubelet logging are core node features
  • All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags
  • No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-104577, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-99782 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-99782 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents
Details

In response to this:

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Jira

OCPBUGS-104577

Related PRs

Release PR Status
4.22 #31306 Merged ✅
4.21 #31426 Merged ✅
4.20 #31430 Merged ✅

Changes (18 files)

New test files (test/extended/node/node_e2e/)

File Test Feature
container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)
image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)
image_registry_config.go Image registry allowedRegistries config image.config (GA)
initcontainer.go Init container restart behavior Core k8s
netns_cleanup.go Network namespace cleanup kubelet/CRI-O
node.go Kubelet log level, cgroupv2, devfuse Core node
pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)
probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

  • node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
  • node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)
  • imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

  • include.go — Added node/node_e2e blank import for test registration
  • go.mod — Moved k8s.io/kubelet from indirect to direct dependency
  • README.md — Documentation for running node tests
  • bindata.go — Regenerated to include new testdata
  • zz_generated.annotations.go — Regenerated test annotations

Testdata

  • testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

  1. Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).

  2. Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.

  3. Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

  • ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
  • Node cgroupv2, devfuse, kubelet logging are core node features
  • All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags
  • No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Chandan9112 @openshift-ci-robot