OCPBUGS-90507: Remove invalid TC6 test - directory deletion breaks kubelet on 5.0

[BhargaviGudi]

Problem

TC6 test fails 100% of the time with 15-minute timeout, blocking daily CI runs.

Root Cause

TC6 deletes /etc/openshift/kubelet.conf.d/ directory to test auto-recreation.

On 5.0, this directory now contains:

• 20-auto-sizing.conf (required for kubelet)
• 99-kubelet-limited-swap.conf (CNV swap config)

When TC6 deletes the entire directory:

1. Removes 20-auto-sizing.conf (required for kubelet startup)
2. Kubelet fails to start
3. oc debug node times out after 15 minutes
4. Node becomes degraded

Solution

Remove TC6 - it's now an invalid test case on 5.0 due to shared directory usage.

Renumbered TC7-TC14 to TC6-TC13 after removal.

Testing

• ✅ make update passed
• ✅ make build passed
• ✅ make verify passed

Summary by CodeRabbit

• Tests
  • Reorganized test case structure for the LimitedSwap test suite, reordering validation scenarios for improved test coverage organization.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-90507, which is invalid:

• expected the bug to target only the "5.0.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Problem

TC6 test fails 100% of the time with 15-minute timeout, blocking daily CI runs.

Root Cause

TC6 deletes /etc/openshift/kubelet.conf.d/ directory to test auto-recreation.

On 5.0, this directory now contains:

• 20-auto-sizing.conf (required for kubelet)
• 99-kubelet-limited-swap.conf (CNV swap config)

When TC6 deletes the entire directory:

1. Removes 20-auto-sizing.conf (required for kubelet startup)
2. Kubelet fails to start
3. oc debug node times out after 15 minutes
4. Node becomes degraded

Solution

Remove TC6 - it's now an invalid test case on 5.0 due to shared directory usage.

Renumbered TC7-TC14 to TC6-TC13 after removal.

Testing

• ✅ make update passed
• ✅ make build passed
• ✅ make verify passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d3120ef9-7b48-4b12-ad97-98afa22ad6ad

📥 Commits

Reviewing files that changed from the base of the PR and between 135cf91 and 6ebe642.

📒 Files selected for processing (1)

• test/extended/node/node_swap_cnv.go

---

Walkthrough

The CNV kubelet LimitedSwap drop-in test suite in node_swap_cnv.go renumbers test cases TC6 through TC13 and swaps their associated behavior descriptions. The former TC6 (drop-in auto-recreation) is replaced by a security/permissions validation, and all subsequent test cases shift down by one position.

Changes

CNV LimitedSwap test case renumbering

Layer / File(s)	Summary
TC6–TC13 title and behavior reassignment test/extended/node/node_swap_cnv.go	TC6 is reassigned to security/permissions validation; TC7 to cluster stability/performance; TC8 to non-CNV workers unaffected; TC9 to conflicting drop-in file precedence; TC10 to multi-node checksum consistency; TC11 to OS swap disabled handling; TC12 to various swap sizes; TC13 to Prometheus swap metrics observability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

verified, ready-for-human-review

Suggested reviewers

• asahay19
• sairameshv

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Most tests lack assertion messages: 66 of 68 error assertions omit meaningful failure messages (e.g., bare Expect(err).NotTo(HaveOccurred()) without context), violating requirement 4. Time.Sleep(...	Add context strings to all error assertions (e.g., 'Expect(err).NotTo(HaveOccurred(), "failed to get kubelet config")') and replace time.Sleep() with Eventually() calls with appropriate timeouts for better stability.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references the specific problem (invalid TC6 test causing failures on 5.0) and the action taken (removal), accurately reflecting the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All 13 Ginkgo test names (TC1-TC13) and the Describe block use stable, deterministic strings without dynamic content like node names, timestamps, UUIDs, or generated identifiers.
Microshift Test Compatibility	✅ Passed	New test suite node_swap_cnv.go has all tests protected from running on MicroShift via BeforeAll hook with exutil.IsMicroShiftCluster() check and g.Skip().
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR removes TC6 and renumbers TC7-TC14 to TC6-TC13; no new Ginkgo tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only test code (renumbering test cases after removing TC6). It does not introduce deployment manifests, operator code, or controllers with topology-assuming scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The file contains only Ginkgo test code with no process-level stdout writes. All logging uses framework.Logf() (safe), no init/main/TestMain functions exist, and the PR changes are test case renumb...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR removes TC6 and renumbers remaining tests (14→13 total). No new Ginkgo e2e tests are added, only existing tests renumbered. Check requirement states "when new tests are added" - not applica...
No-Weak-Crypto	✅ Passed	PR modifies test file to remove TC6 and renumber remaining tests. MD5 checksum usage is for configuration drift detection in tests, not security-critical cryptography. No weak crypto implementation...
Container-Privileges	✅ Passed	PR modifies test file and Kubernetes manifests; no container-privilege escalations found. All manifests contain only kubelet configs and operator resources without privileged containers, hostPID/Ne...
No-Sensitive-Data-In-Logs	✅ Passed	Test file contains no sensitive data logging; bearer token retrieved but never logged, and no passwords, API keys, PII, session IDs, or credentials exposed in logs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BhargaviGudi]

/jira refresh

[openshift-ci-robot]

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-90507, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[BhargaviGudi]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning

[openshift-ci]

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/01f016b0-6bcf-11f1-9a52-cb1165f84022-0