[wip] TRT-2539: Fix output capture in ginkgo RunSpec to capture stdout/stderr #30769
Conversation
… stdout/stderr
This is an experimental change to test in CI - do not merge.
When running tests via openshift-tests run-test, only output written to
ginkgo.GinkgoWriter was captured in the test result's output field. Raw
stdout/stderr output from the test was not captured because RunSpec used
NoopOutputInterceptor{}.
This change introduces ForwardingOutputInterceptor which:
- Captures stdout/stderr so it's available in CapturedStdOutErr
- Forwards output in real-time to the terminal so local run-test usage
isn't silent until test completion
The stdout clone is created using platform-specific dupStdout() before
the interceptor redirects file descriptors, ensuring output is always
forwarded to the original terminal.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@stbenjam: This pull request references TRT-2539 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pipeline-required |
|
/pipeline required |
|
Scheduling required tests: |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This is an experimental change to test in CI - do not merge. Seeing the impact on artifact sizes...
When running tests via openshift-tests run-test, only output written to ginkgo.GinkgoWriter was captured in the test result's output field. Raw stdout/stderr output from the test was not captured because RunSpec used NoopOutputInterceptor{}.
This change introduces ForwardingOutputInterceptor which:
The stdout clone is created using platform-specific dupStdout() before the interceptor redirects file descriptors, ensuring output is always forwarded to the original terminal.