-
Notifications
You must be signed in to change notification settings - Fork 4.8k
NO-JIRA: Simplify zstd:chunked image test to use prebuilt image. #30739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Scheduling required tests: |
|
|
@bertinatto Can you help me mirror the image to the test environment as an owner of |
Image mirrored. |
|
/retest |
|
@cpmeadors Can you PTAL? |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: ac008db
New tests seen in this PR at sha: ac008db
|
|
/lgtm |
|
@bertinatto Can you approve it? |
|
I believe you will want to update ci-test-mapping similar to zstd:chunked Image should successfully run date command |
|
/approve |
bertinatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
for the images
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, bitoku, haircommander, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bitoku: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI |
|
@bitoku: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@bitoku: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Something wrong with okd-scos-images, other PRs are failing. |
It doesn't need to rely on Feature:Build. I changed it to use a prebuilt image in https://quay.io/repository/crio/zstd-chunked?tab=tags
We need to use the image compressed in zstd:chunked format to verify zstd:chunked image can be used in openshift.