OSDOCS-16950#CQA work Stor6 - LVMS updating monitoring uninstalling - #116576
Conversation
openshift-ci
Bot
added
the
size/L
|
🤖 Mon Aug 03 20:18:24 - Prow CI generated the docs preview: https://116576--ocpdocs-pr.netlify.app/ |
lpettyjo
added
the
merge-review-needed
skopacz1
added
the
merge-review-in-progress
skopacz1
left a comment
skopacz1
left a comment
There was a problem hiding this comment.
Left a few comments, otherwise this LGTM if merged in close coordination with your PR that puts the new module back into the assembly
There was a problem hiding this comment.
I understand that this is being added back to the assembly in #116579, but I am not sure this PR should be merged without making sure this file is included back in the assembly right in this PR.
It would just be simpler to make sure this content is still included after merging, and to be able to check the preview for rendering errors.
This file LGTM from what I can see, but please consider adding this to an assembly in this PR and carefully looking at the preview before merge
skopacz1
added
ok-to-merge
and removed
merge-review-in-progress
02fd8fd to
6710fbb
Compare
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-5.0 |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
@lpettyjo: new pull request created: #117364 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.20 |
|
@lpettyjo: new pull request created: #117365 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lpettyjo: new pull request created: #117366 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lpettyjo: new pull request created: #117367 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Split from #115159. CQA updates for LVMS updating, monitoring, uninstalling, and must-gather modules.
https://issues.redhat.com/browse/OSDOCS-16950
Dear reviewer, please check the assembly file as well (#116579).