Skip to content

OSDOCS-16950#CQA work Stor6 - LVMS snapshots and clones - #116575

Merged
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16950-lvms-snapshots
Aug 5, 2026
Merged

OSDOCS-16950#CQA work Stor6 - LVMS snapshots and clones#116575
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16950-lvms-snapshots

Conversation

@lpettyjo

@lpettyjo lpettyjo commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Split from #115159. CQA updates for LVMS volume snapshots and clones modules.

https://issues.redhat.com/browse/OSDOCS-16950

Dear reviewer, please check the assembly file as well (#116579).

@ocpdocs-previewbot

ocpdocs-previewbot commented Jul 27, 2026

Copy link
Copy Markdown

@lpettyjo lpettyjo added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 27, 2026
@cbippley

Copy link
Copy Markdown
Contributor

/label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci Bot added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 27, 2026
@cbippley

cbippley commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

PR Summary & Visual Review Guide

PR: OSDOCS-16950 CQA work Stor6 - LVMS snapshots and clones
Files changed: 7 | +46 / -43

Changes Overview

File Change
lvms-about-volume-clones.adoc Added abstract, added subsection anchor ID
lvms-about-volume-snapshots.adoc Added abstract, added subsection anchor ID
lvms-creating-volume-clones.adoc Added abstract, converted callouts to definition lists, removed blank lines after section markers
lvms-creating-volume-snapshots.adoc Added abstract, converted callouts to definition lists, removed blank lines after section markers
lvms-deleting-volume-clones.adoc Added abstract, removed blank lines after section markers
lvms-deleting-volume-snapshots.adoc Added abstract, removed blank lines after section markers
lvms-restoring-volume-snapshots.adoc Added abstract, converted callouts to definition lists, removed blank lines after section markers

Visual Review Guide

All 7 modules render on a single assembly page. Review each section by scrolling or using the anchor links below.

Base URL: LVMS Storage (OCP)

1. Volume Clones — concepts & procedures

  • About volume clonesCheck: abstract renders, "Limitations" subsection has anchor ID, blank line after heading
  • Creating volume clonesCheck: abstract renders, callouts replaced with definition list, YAML example clean (no orphaned callout markers)
  • Deleting volume clonesCheck: abstract renders, section markers compact

2. Volume Snapshots — concepts & procedures


All preview URLs verified (HTTP 200).

@cbippley cbippley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, otherwise LGTM. I didn't review #116579 because the build is broken.

Comment thread modules/lvms-restoring-volume-snapshots.adoc Outdated
Comment thread modules/lvms-creating-volume-snapshots.adoc Outdated
Comment thread modules/lvms-creating-volume-snapshots.adoc Outdated
Comment thread modules/lvms-creating-volume-snapshots.adoc Outdated
Comment thread modules/lvms-deleting-volume-snapshots.adoc Outdated
Comment thread modules/lvms-deleting-volume-clones.adoc Outdated
@cbippley

Copy link
Copy Markdown
Contributor

/remove-label merge-review-in-progress

@cbippley cbippley added this to the Continuous Release milestone Jul 27, 2026
@openshift-ci openshift-ci Bot removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 27, 2026
@lpettyjo
lpettyjo force-pushed the OSDOCS-16950-lvms-snapshots branch from 1afc991 to f0f8b66 Compare August 3, 2026 23:00
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo
lpettyjo merged commit f4840b9 into openshift:main Aug 5, 2026
2 checks passed
@lpettyjo

lpettyjo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-5.0

@lpettyjo

lpettyjo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #117368

Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo

lpettyjo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.21

@lpettyjo

lpettyjo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #117369

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #117370

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #117371

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants