Skip to content

OSDOCS-17733 [NETOBSERV] Loki example with schema v12#105263

Merged
mburke5678 merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-17733
Mar 17, 2026
Merged

OSDOCS-17733 [NETOBSERV] Loki example with schema v12#105263
mburke5678 merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-17733

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jan 22, 2026

OSDOCS-17733 [NETOBSERV] Loki example with schema v12

Version(s):
4.12, 4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-17733

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2026
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 22, 2026

@gwynnemonahan gwynnemonahan force-pushed the OSDOCS-17733 branch 2 times, most recently from d1a0a27 to b80cda4 Compare February 13, 2026 16:41
@gwynnemonahan
Copy link
Contributor Author

Rebased against main 02/13/2026 AM.

Copy link

@stleerh stleerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in this doc, I see:

apiVersion: loki.grafana.com/v1
kind: LokiStack
metadata:
  name: loki
  namespace: netobserv # (1)

We now recommend to use a different namespace from netobserv for Loki, so we should document the best practice.

Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 13, 2026
@gwynnemonahan
Copy link
Contributor Author

Rebased 03/10/2026

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2026

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

Hey @stleerh ,

Also in this doc, I see:

apiVersion: loki.grafana.com/v1
kind: LokiStack
metadata:
  name: loki
  namespace: netobserv # (1)

We now recommend to use a different namespace from netobserv for Loki, so we should document the best practice.

This will be addressed as part of the change to Callouts, which is being handled by a separate Jira issue and corresponding PR.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 17, 2026
@mburke5678 mburke5678 merged commit c3e622e into openshift:main Mar 17, 2026
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.17

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.19

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.20

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.21

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.22

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108537

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108538

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108539

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108540

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108541

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108542

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108543

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108544

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108545

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@mburke5678: new pull request created: #108546

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants