Skip to content

OSDOCS-16161-re: Removed the nodes-nodes-audit-policy-custom.adoc note #105064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dfitzmau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-16161-re: Removed the nodes-nodes-audit-policy-custom.adoc note #105064

dfitzmau wants to merge 1 commit into from

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jan 20, 2026 •
edited
Loading

Version(s):
4.16+

Issue:
OSDOCS-16161

Link to docs preview:

  • SME has approved this change (SAYED AMRIN HANIF/Damien Grisonnet).
  • QE has approved this change (Rahul Gangwar).

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2026
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 20, 2026 •
edited
Loading

🤖 Wed Jan 21 09:33:58 - Prow CI generated the docs preview:

https://105064--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/audit-log-policy-config.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jan 20, 2026
View reviewed changes
@dfitzmau dfitzmau force-pushed the OSDOCS-16161-re branch 2 times, most recently from 7c3c0fc to c29d0bd Compare January 20, 2026 16:15
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2026
dfitzmau
dfitzmau commented Jan 20, 2026
View reviewed changes
modules/nodes-nodes-audit-policy-custom.adoc Outdated
+
where:
+
`audit.customRules`:: Specifies the profile to use for that group. You can add one or more groups. These custom rules take precedence over the top-level profile field. The custom rules are evaluated from top to bottom, and the first that matches is applied.
Copy link
Contributor Author

@dfitzmau dfitzmau Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

These custom rules take precedence over the top-level profile field. The custom rules are evaluated from top to bottom, and the first that matches is applied.

Copy link

@samuano76 samuano76 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the documentation preview, and it aligns well with what was observed in the support case. I agree with removing it.

Copy link
Contributor Author

@dfitzmau dfitzmau Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@dfitzmau dfitzmau force-pushed the OSDOCS-16161-re branch 2 times, most recently from c372be4 to 1606b52 Compare January 21, 2026 09:08
@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2026

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@samuano76 samuano76 samuano76 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dfitzmau @ocpdocs-previewbot @samuano76 @ocpdocs-vale-bot