-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OLS-2509: Update procedure for Providing custom knowledge to the LLM #105053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lightspeed-docs-main
Are you sure you want to change the base?
Conversation
|
@rh-tokeefe: This pull request references OLS-2509 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rh-tokeefe: This pull request references OLS-2509 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Tue Jan 20 18:58:58 - Prow CI generated the docs preview: |
|
@rh-tokeefe: This pull request references OLS-2509 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| ---- | ||
| <1> Where `image` specifies the tag for the image that was pushed to the image registry so that the {ols-long} Operator can access the custom content. The {ols-long} Operator can work with more than one RAG database that you create. | ||
|
|
||
| . Specify pull secrets in the `OLSSpec` section of the `OLSConfig` CR file. Pull secrets contain authentication credentials for remote image registries that {ols-long} uses to pull RAG BYO Knowledge images from image registries that require authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rh-tokeefe Pull secrets are not mandatory, they're only needed if the BYOK images live in registries that need authentication and are not covered by the cluster-wide pull secret. May be just prepend with "If needed, ..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a doc practice of noting steps as Optional. I've updated the PR.
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Affects:
lightspeed-main
lightspeed-docs-1.0
PR must be CP'd back to the lightspeed-docs-1.0 branch.
Issue: https://issues.redhat.com/browse/OLS-2509
Link to docs preview:
https://105053--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#providing-custom-knowledge-to-the-llm_ols-configuring-openshift-lightspeed
QE review:
Additional information: