-
Notifications
You must be signed in to change notification settings - Fork 1.9k
RHDEVDOCS-7133: Content creation for GitOps 1.17.4 #105023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gitops-docs-1.17
Are you sure you want to change the base?
RHDEVDOCS-7133: Content creation for GitOps 1.17.4 #105023
Conversation
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-7133 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Tue Jan 20 07:44:00 - Prow CI generated the docs preview: |
|
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we missed RN for https://issues.redhat.com/browse/GITOPS-8225
| [IMPORTANT] | ||
| ==== | ||
| After completing the upgrade, run the `audit-operator-roles.sh` audit script to review namespace-scoped access created by the {gitops-title} Operator. The script identifies `Role` and `RoleBinding` objects that grant cross-namespace access when the _Applications in any namespace_ feature or _ApplicationSets in any namespace_ feature is enabled using the Argo CD custom resource (CR) (`.spec.sourceNamespaces` and `.spec.applicationSet.sourceNamespaces`). These features are disabled by default. The script scans all namespaces and reports `Role`/`RoleBinding` combinations that meet the following conditions: | ||
| * Grant access to the `argoproj.io/Application` resource | ||
| * Are labeled with `app.kubernetes.io/part-of=argocd` | ||
| * Bind to a service account in a different namespace, resulting in cross-namespace access | ||
| Review the script output to ensure that cross-namespace access is limited to the intended namespaces only. | ||
| For more information about the script, see link:https://github.com/redhat-developer/gitops-operator/blob/master/scripts/audit-namespace-roles/audit-operator-roles.sh[Audit Operator script]. | ||
| For more information about the steps to execute the script, see link:https://github.com/redhat-developer/gitops-operator/blob/master/scripts/audit-namespace-roles/README.md[Audit Operator script readme]. | ||
| ==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is not required for the new version.
|
@anandf Do we need an entry for https://issues.redhat.com/browse/GITOPS-7568? |
Do we need one for https://issues.redhat.com/browse/GITOPS-7992? |
Not required. The target down release note covers this |
|
@varshab1210 @svghadi, Fixed all your suggestions in this PR: #105112. @Dhruv-Soni11, Please feel free to close the PR when you are back. Thanks |
Version(s):
None for CP
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-7133
Link to docs preview:
QE review:
SME review:
QE review:
Peer review:
Additional information: