Skip to content

Conversation

@Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Jan 20, 2026

Version(s):

None for CP

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-7136

Link to docs preview:

Release notes for Red Hat OpenShift GitOps 1.18.3

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026

@Dhruv-Soni11: This pull request references RHDEVDOCS-7136 which is a valid jira issue.

Details

In response to this:

Version(s):

None for CP

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-7136

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2026
@ocpdocs-previewbot
Copy link

🤖 Tue Jan 20 07:24:39 - Prow CI generated the docs preview:

https://105022--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes-1-18.html

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2026

@Dhruv-Soni11: This pull request references RHDEVDOCS-7136 which is a valid jira issue.

Details

In response to this:

Version(s):

None for CP

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-7136

Link to docs preview:

Release notes for Red Hat OpenShift GitOps 1.18.3

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +12 to +25
[IMPORTANT]
====
After completing the upgrade, run the `audit-operator-roles.sh` audit script to review namespace-scoped access created by the {gitops-title} Operator. The script identifies `Role` and `RoleBinding` objects that grant cross-namespace access when the _Applications in any namespace_ feature or _ApplicationSets in any namespace_ feature is enabled using the Argo CD custom resource (CR) (`.spec.sourceNamespaces` and `.spec.applicationSet.sourceNamespaces`). These features are disabled by default. The script scans all namespaces and reports `Role`/`RoleBinding` combinations that meet the following conditions:
* Grant access to the `argoproj.io/Application` resource
* Are labeled with `app.kubernetes.io/part-of=argocd`
* Bind to a service account in a different namespace, resulting in cross-namespace access
Review the script output to ensure that cross-namespace access is limited to the intended namespaces only.
For more information about the script, see link:https://github.com/redhat-developer/gitops-operator/blob/master/scripts/audit-namespace-roles/audit-operator-roles.sh[Audit Operator script].
For more information about the steps to execute the script, see link:https://github.com/redhat-developer/gitops-operator/blob/master/scripts/audit-namespace-roles/README.md[Audit Operator script readme].
====
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is not required for the new version.

Copy link

@varshab1210 varshab1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== Fixed issues

Reconciliation timeout configuration mapping fix::
Before this update, reconciliation timeout values configured in the `extraConfig` field were not correctly mapped to the Operator's environment variables, particularly when `timeout.reconciliation` was set to 0. With this update, the `timeout.reconciliation` field is explicitly mapped to the appropriate environment variable in the Operator's deployment logic, ensuring that the Operator correctly recognizes and applies user-defined timeouts for consistent control over sync cycles.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before this update, reconciliation timeout values configured in the `extraConfig` field were not correctly mapped to the Operator's environment variables, particularly when `timeout.reconciliation` was set to 0. With this update, the `timeout.reconciliation` field is explicitly mapped to the appropriate environment variable in the Operator's deployment logic, ensuring that the Operator correctly recognizes and applies user-defined timeouts for consistent control over sync cycles.
Before this update, reconciliation timeout values configured in the `extraConfig` field were not correctly mapped to the Operator's environment variables. With this update, the `timeout.reconciliation` field is explicitly mapped to the appropriate environment variable in the Operator's deployment logic, ensuring that the Operator correctly recognizes and applies user-defined timeouts for consistent control over sync cycles.

cc: @alkakumari016 @svghadi


[IMPORTANT]
====
After completing the upgrade, run the `audit-operator-roles.sh` audit script to review namespace-scoped access created by the {gitops-title} Operator. The script identifies `Role` and `RoleBinding` objects that grant cross-namespace access when the _Applications in any namespace_ feature or _ApplicationSets in any namespace_ feature is enabled using the Argo CD custom resource (CR) (`.spec.sourceNamespaces` and `.spec.applicationSet.sourceNamespaces`). These features are disabled by default. The script scans all namespaces and reports `Role`/`RoleBinding` combinations that meet the following conditions:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added for 1.18.2, is it required with 1.18.3 as well?
cc: @svghadi

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's not required.

@varshab1210
Copy link

Looks like we missed RN for

https://issues.redhat.com/browse/GITOPS-8225 depends on which version the user is upgrading from. We introduced 3 replicas for haproxy in 1.17.0

[id="RHSA-XXXX:NNNN-gitops-1-18-3-security-update-advisory_{context}"]
=== RHSA-XXXX:NNNN - {gitops-title} 1.18.3 security update advisory

Issued: 2025-XX-NN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Issued: 2025-XX-NN
Issued: 2026-XX-NN

@shipsing
Copy link
Contributor

@varshab1210 @svghadi, Fixed all your suggestions in this PR: #105113. @Dhruv-Soni11, Please feel free to close the PR when you are back. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants