Skip to content

[release-4.20] OCPBUGS-94907,OCPBUGS-91324: Bump golang.org/x/net to openshift-sustaining/net v0.50.0-sec.2 - #2342

Open
germanparente wants to merge 1 commit into
openshift:release-4.20from
germanparente:fix-CVE-2026-25681-release-4.20
Open

[release-4.20] OCPBUGS-94907,OCPBUGS-91324: Bump golang.org/x/net to openshift-sustaining/net v0.50.0-sec.2#2342
germanparente wants to merge 1 commit into
openshift:release-4.20from
germanparente:fix-CVE-2026-25681-release-4.20

Conversation

@germanparente

Copy link
Copy Markdown

Summary

  • Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.20
  • Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.50.0-sec.2, avoiding a Go toolchain bump from 1.24.0 to 1.25.0 that a direct upgrade to v0.55.0 would require
  • Go toolchain remains at go 1.24.0

Test plan

  • Verify go mod verify passes
  • Verify go build ./... succeeds
  • Verify CI passes
  • Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-91324, which is invalid:

  • expected dependent Jira Issue OCPBUGS-94941 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.20
  • Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.50.0-sec.2, avoiding a Go toolchain bump from 1.24.0 to 1.25.0 that a direct upgrade to v0.55.0 would require
  • Go toolchain remains at go 1.24.0

Test plan

  • Verify go mod verify passes
  • Verify go build ./... succeeds
  • Verify CI passes
  • Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fc2b112b-ec90-41a8-bb31-bb1aeff0b842

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from atiratree and ingvagabund August 4, 2026 22:33
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@germanparente

Copy link
Copy Markdown
Author

since 4.21 is already in golang.org/x/net v0.56.0

/label jira/skip-dependent-bug-check

@openshift-ci openshift-ci Bot added the jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. label Aug 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-91324, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Summary

  • Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.20
  • Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.50.0-sec.2, avoiding a Go toolchain bump from 1.24.0 to 1.25.0 that a direct upgrade to v0.55.0 would require
  • Go toolchain remains at go 1.24.0

Test plan

  • Verify go mod verify passes
  • Verify go build ./... succeeds
  • Verify CI passes
  • Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MrSanketkumar

Copy link
Copy Markdown

/retitle [release-4.20] OCPBUGS-94907,OCPBUGS-91324: Bump golang.org/x/net to openshift-sustaining/net v0.50.0-sec.2

@openshift-ci openshift-ci Bot changed the title Fix for OCPBUGS-91324: CVE-2026-25681 [release-4.20] OCPBUGS-94907,OCPBUGS-91324: Bump golang.org/x/net to openshift-sustaining/net v0.50.0-sec.2 Aug 6, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-94907, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-91324, which is valid.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.20
  • Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.50.0-sec.2, avoiding a Go toolchain bump from 1.24.0 to 1.25.0 that a direct upgrade to v0.55.0 would require
  • Go toolchain remains at go 1.24.0

Test plan

  • Verify go mod verify passes
  • Verify go build ./... succeeds
  • Verify CI passes
  • Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown
Author

/test security

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@germanparente: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 988c8d9 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants