DNM: Test: disable pod restart workaround after file-system restore#2133
DNM: Test: disable pod restart workaround after file-system restore#2133weshayutin wants to merge 1 commit intooadp-devfrom
Conversation
Comment out the KOPIA post-restore pod deletion to test whether the OVN-Kubernetes networking workaround is still required. If E2E tests pass without it, this workaround can be removed entirely. Made-with: Cursor
WalkthroughThe post-restore pod restart workaround for KOPIA (file-system) backups has been disabled across two e2e test files by commenting out the corresponding logic blocks and adding TODO comments for future reassessment of the workaround's necessity. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/e2e/backup_restore_cli_suite_test.go (1)
3-15:⚠️ Potential issue | 🔴 CriticalRemove unused imports that cause compilation failure.
After the workaround code at lines 178-194 was commented out, the imports
context(line 4) andmetav1(line 12) are no longer used anywhere in the file. Go treats unused imports as a compilation error, so this file will not compile.Remove both imports:
Fix
import ( - "context" "fmt" "log" "strings" "time" "github.com/onsi/ginkgo/v2" "github.com/onsi/gomega" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "github.com/openshift/oadp-operator/tests/e2e/lib" )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/e2e/backup_restore_cli_suite_test.go` around lines 3 - 15, Remove the now-unused imports "context" and "metav1" from the import block introduced in the tests e2e import list (they were only needed for the workaround commented out at lines ~178-194); edit the import block to delete the symbols context and metav1 so the file compiles without unused imports.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/e2e/backup_restore_cli_suite_test.go`:
- Around line 3-15: Remove the now-unused imports "context" and "metav1" from
the import block introduced in the tests e2e import list (they were only needed
for the workaround commented out at lines ~178-194); edit the import block to
delete the symbols context and metav1 so the file compiles without unused
imports.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ddc4c80d-432b-4569-9c8e-59b21c8c36c5
📒 Files selected for processing (2)
tests/e2e/backup_restore_cli_suite_test.gotests/e2e/backup_restore_suite_test.go
weshayutin
changed the title
|
@weshayutin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Note Responses generated with Claude Closing this PR because it was pushed directly to the protected |
2 participants
Summary
backup_restore_suite_test.goandbackup_restore_cli_suite_test.goTest plan
Made with Cursor