disable fail-fast, set 0 timeout for pvc delete

[weshayutin]

Why the changes were made

testing out changes to ci params

[coderabbitai]

Walkthrough

Modifications to the Makefile add --fail-fast=false to GINKGO_FLAGS for non-fail-fast e2e test execution. In k8s_common_helpers.go, PVC deletion logic is updated to import ptr from k8s.io/utils and enforce immediate deletion via GracePeriodSeconds=0.

Changes

Cohort / File(s)	Summary
Test Execution Configuration Makefile	Adds --fail-fast=false flag to GINKGO_FLAGS variable to disable fail-fast behavior for e2e tests.
PVC Deletion Logic tests/e2e/lib/k8s_common_helpers.go	Adds import for ptr from k8s.io/utils; modifies DeleteAllPVCsInNamespace to use DeleteOptions with GracePeriodSeconds set to 0 (via ptr.To(int64(0))) for immediate PVC deletion instead of relying on default grace period.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Makefile: Verify that --fail-fast=false is the correct configuration for the intended test execution behavior.
• k8s_common_helpers.go: Confirm that changing GracePeriodSeconds from default to 0 aligns with the intended PVC cleanup semantics and does not introduce unexpected deletion behavior in the test environment.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5048a8f and 778e057.

📒 Files selected for processing (2)

• Makefile (1 hunks)
• tests/e2e/lib/k8s_common_helpers.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• Makefile
• tests/e2e/lib/k8s_common_helpers.go

🔇 Additional comments (2)

tests/e2e/lib/k8s_common_helpers.go (2)

20-20: LGTM: Import added for pointer utility.

The ptr import from k8s.io/utils/ptr is correctly added to support the pointer conversion needed for GracePeriodSeconds.

---

300-300: LGTM: Immediate PVC deletion for test cleanup.

Setting GracePeriodSeconds to 0 enforces immediate deletion of PVCs, which is appropriate for test cleanup scenarios where you want to ensure resources are removed quickly without waiting for the default grace period.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weshayutin
Once this PR has been reviewed and has the lgtm label, please assign mrnold for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

/retest

[kaovilai]

/retest

ai-retester: The e2e-test-cli-aws-e2e step failed due to the test suite failing. Specifically, the "MySQL application two Vol CSI via CLI" test case failed, indicating a problem with the backup and restore functionality related to CSI volumes and the OADP CLI. The error message indicates inability to connect the deployed application via Route.

The e2e-test-aws-e2e step failed because the Ginkgo test suite timed out after an hour, with two tests failing or timing out. The test container exited with code 2.

[kaovilai]

/retest

ai-retester: The e2e-test-aws test failed because the "MySQL application two Vol CSI " test failed. The errors indicate a failure to connect to the "todolist" service via the external route and via the proxy pod's curl command. Specifically, it could not connect to the server running on port 8000 "PodInitializing".

[kaovilai]

/retest

ai-retester: The "e2e-test-aws" step timed out, and the "MySQL application DATAMOVER" test within it failed. It also seems like there maybe be some other test and deployment related issues within that step.

The e2e tests failed. Specifically, the "MySQL application KOPIA" test timed out after 540 seconds when a container in a MySQL pod repeatedly failed its ready check, likely preventing the tests from completing.

[openshift-ci]

@weshayutin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.20-e2e-test-aws	778e057	link	false	/test 4.20-e2e-test-aws
ci/prow/4.19-e2e-test-aws	778e057	link	true	/test 4.19-e2e-test-aws
ci/prow/4.19-e2e-test-kubevirt-aws	778e057	link	true	/test 4.19-e2e-test-kubevirt-aws
ci/prow/4.20-e2e-test-kubevirt-aws	778e057	link	false	/test 4.20-e2e-test-kubevirt-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.