OBSINTA-993: Tests for incident detection coo 1.4.0 changes

web/cypress.config.ts

@@ -52,6 +52,7 @@ export default defineConfig({
     typeDelay: 200,
   },
   fixturesFolder: 'cypress/fixtures',
+  pageLoadTimeout: 60000,
   defaultCommandTimeout: 80000, //due to performance loading issue on console
   readyTimeoutMilliseconds: 120000,
   installTimeoutMilliseconds: 600000,

web/cypress/e2e/incidents/01.incidents.cy.ts

@@ -2,13 +2,11 @@
 The test verifies the basic functionality of the Incidents page and serves
 as a verification that the Incidents View is working as expected.
 
-Currently, it depends on an alert being present in the cluster.
-In the future, mocking requests / injecting alerts should be considered.
-Natural creation of the alert is done in the 00.coo_incidents_e2e.cy.ts test, 
-but takes significant time.
+All tests use mocked data. Tests 1-3 use a default fixture (incident content
+is irrelevant for toolbar/filter verification). Tests 4-5 switch mocks
+mid-test for empty state and traversal scenarios.
 */
 
-import { commonPages } from '../../views/common';
 import { incidentsPage } from '../../views/incidents-page';
 
 const MCP = {
@@ -26,24 +24,13 @@ const MP = {
   operatorName: 'Cluster Monitoring Operator',
 };
 
-const ALERTNAME = 'Watchdog';
-const NAMESPACE = 'openshift-monitoring';
-const SEVERITY = 'Critical';
-const ALERT_DESC = 'This is an alert meant to ensure that the entire alerting pipeline is functional. This alert is always firing, therefore it should always be firing in Alertmanager and always fire against a receiver. There are integrations with various notification mechanisms that send a notification when this alert is not firing. For example the "DeadMansSnitch" integration in PagerDuty.'
-const ALERT_SUMMARY = 'An alert that should always be firing to certify that Alertmanager is working properly.'
 describe('BVT: Incidents - UI', { tags: ['@smoke', '@incidents'] }, () => {
   before(() => {
     cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
+    cy.mockIncidentFixture('incident-scenarios/1-single-incident-firing-critical-and-warning-alerts.yaml');
   });
 
 
-  beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
-    // Temporary workaround for testing against locally built instances.
-    cy.transformMetrics();
-  });
-
   it('1. Admin perspective - Incidents page - Toolbar and charts toggle functionality', () => {
     cy.log('1.1 Verify toolbar and toggle charts button');
     incidentsPage.elements.toolbar().should('be.visible');
@@ -80,24 +67,23 @@ describe('BVT: Incidents - UI', { tags: ['@smoke', '@incidents'] }, () => {
     cy.log('4.1 Verify chart titles are visible');
     incidentsPage.elements.incidentsChartTitle().should('be.visible');
     incidentsPage.elements.alertsChartTitle().should('be.visible');
-
     cy.log('4.2 Verify alerts chart shows empty state');
     incidentsPage.elements.alertsChartEmptyState().should('exist');
   });
 
   it('5. Admin perspective - Incidents page - Traverse Incident Table', () => {
+    incidentsPage.goTo();
+
     cy.log('5.1 Traverse incident table');
-    incidentsPage.clearAllFilters();
     cy.mockIncidents([]);
     incidentsPage.findIncidentWithAlert('TargetAlert').should('be.false');
 
     cy.log('5.2 Verify traversing incident table works when the alert is not present');
     cy.mockIncidentFixture('incident-scenarios/1-single-incident-firing-critical-and-warning-alerts.yaml');
     incidentsPage.findIncidentWithAlert('TargetAlert').should('be.false');
 
-    incidentsPage.clearAllFilters
     cy.log('5.3 Verify traversing incident table works when the alert is present');
     cy.mockIncidentFixture('incident-scenarios/6-multi-incident-target-alert-scenario.yaml');
-    incidentsPage.findIncidentWithAlert('TargetAlert').should('be.true');    
+    incidentsPage.findIncidentWithAlert('TargetAlert').should('be.true');
   });
 });

web/cypress/e2e/incidents/regression/01.reg_filtering.cy.ts

@@ -32,8 +32,6 @@ describe('Regression: Incidents Filtering', { tags: ['@incidents'] }, () => {
   });
 
   beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
     cy.log('Setting up comprehensive filtering test scenarios');
     cy.mockIncidentFixture('incident-scenarios/7-comprehensive-filtering-test-scenarios.yaml');
   });

web/cypress/e2e/incidents/regression/02.reg_ui_charts_comprehensive.cy.ts

@@ -92,7 +92,6 @@ describe('Regression: Charts UI - Comprehensive', { tags: ['@incidents'] }, () =
   });
 
   beforeEach(() => {
-    incidentsPage.goTo();
     cy.mockIncidentFixture('incident-scenarios/12-charts-ui-comprehensive.yaml');
   });
 

web/cypress/e2e/incidents/regression/02.reg_ui_tooltip_boundary_times.cy.ts

@@ -0,0 +1,165 @@
+/*
+Regression test for mixed severity interval boundary times (Section 2.3.3).
+
+Test 1 (OU-1205): Verifies tooltip End times at severity interval boundaries
+are rounded to 5-minute precision. Without rounding, consecutive interval end
+times can land on non-5-minute values (e.g., "10:58" instead of "11:00").
+
+Test 2 (OU-1221, XFAIL): Verifies Start times shown in incident tooltips match
+alert tooltips and alerts table, and that consecutive segment boundaries align
+with no 5-minute gap between End of one segment and Start of the next.
+*/
+
+import { incidentsPage } from '../../../views/incidents-page';
+
+const MCP = {
+  namespace: Cypress.env('COO_NAMESPACE'),
+  packageName: 'cluster-observability-operator',
+  operatorName: 'Cluster Observability Operator',
+  config: {
+    kind: 'UIPlugin',
+    name: 'monitoring',
+  },
+};
+
+const MP = {
+  namespace: 'openshift-monitoring',
+  operatorName: 'Cluster Monitoring Operator',
+};
+
+describe('Regression: Mixed Severity Interval Boundary Times', { tags: ['@incidents', '@xfail'] }, () => {
+
+  before(() => {
+    cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
+  });
+
+  beforeEach(() => {
+    cy.mockIncidentFixture('incident-scenarios/21-multi-severity-boundary-times.yaml');
+  });
+
+  const extractTime = (tooltipText: string, field: 'Start' | 'End'): string => {
+    const afterField = tooltipText.split(field)[1] || '';
+    const match = afterField.match(/(\d{1,2}:\d{2}(\s*[AP]M)?)/);
+    return match ? match[1].trim() : '';
+  };
+
+  it('1. Tooltip End times at severity boundaries show 5-minute rounded values', () => {
+    const verifyEndTimeRounded = (label: string) => {
+      incidentsPage.elements.tooltip()
+        .invoke('text')
+        .then((text) => {
+          cy.log(`${label} tooltip: "${text}"`);
+
+          if (text.match(/End.*---/)) {
+            cy.log(`${label}: Firing, End shows --- (skipped)`);
+            return;
+          }
+
+          const endPart = text.split('End')[1];
+          expect(endPart, `${label}: should contain End time`).to.exist;
+
+          const timeMatch = endPart.match(/(\d{1,2}):(\d{2})/);
+          expect(timeMatch, `${label}: End time should be parseable`).to.not.be.null;
+
+          const minutes = parseInt(timeMatch[2], 10);
+          const remainder = minutes % 5;
+          expect(remainder, `${label}: End minutes (${minutes}) should be divisible by 5, remainder=${remainder}`).to.equal(0);
+          cy.log(`${label}: End ${timeMatch[1]}:${timeMatch[2]} - minutes divisible by 5`);
+        });
+    };
+
+    cy.log('1.1 Verify multi-severity incident loaded');
+    incidentsPage.clearAllFilters();
+    incidentsPage.setDays('1 day');
+    incidentsPage.elements.incidentsChartContainer().should('be.visible');
+    incidentsPage.elements.incidentsChartBarsGroups().should('have.length', 1);
+
+    cy.log('1.2 Verify bar has multiple severity segments');
+    incidentsPage.getIncidentBarVisibleSegments(0).then((segments) => {
+      expect(segments.length, 'Multi-severity bar should have at least 2 visible segments')
+        .to.be.greaterThan(1);
+      cy.log(`Found ${segments.length} visible severity segments`);
+    });
+
+    cy.log('1.3 Check first segment end time (Info -> Warning boundary)');
+    incidentsPage.hoverOverIncidentBarSegment(0, 0);
+    verifyEndTimeRounded('First segment');
+
+    cy.log('1.4 Check second segment end time (Warning -> Critical boundary)');
+    incidentsPage.hoverOverIncidentBarSegment(0, 1);
+    verifyEndTimeRounded('Second segment');
+
+    cy.log('1.5 Check third segment end time (Critical end)');
+    incidentsPage.hoverOverIncidentBarSegment(0, 2);
+    verifyEndTimeRounded('Third segment');
+
+    cy.log('Verified: All tooltip End times at severity boundaries are at 5-minute precision (OU-1205)');
+  });
+
+  it('2. Start times match between incident tooltip, alert tooltip, and table; consecutive boundaries align',
+    () => {
+    cy.log('2.1 Setup: verify multi-severity incident loaded');
+    incidentsPage.clearAllFilters();
+    incidentsPage.setDays('1 day');
+    incidentsPage.elements.incidentsChartContainer().should('be.visible');
+    incidentsPage.elements.incidentsChartBarsGroups().should('have.length', 1);
+    cy.pause();
+
+    cy.log('2.2 Consecutive interval boundaries: End of segment 1 should equal Start of segment 2');
+    incidentsPage.hoverOverIncidentBarSegment(0, 0);
+    incidentsPage.elements.tooltip().invoke('text').then((firstText) => {
+      const firstEnd = extractTime(firstText, 'End');
+      cy.log(`First segment End: ${firstEnd}`);
+      expect(firstEnd, 'First segment End should be parseable').to.not.be.empty;
+
+      incidentsPage.hoverOverIncidentBarSegment(0, 1);
+      incidentsPage.elements.tooltip().invoke('text').then((secondText) => {
+        const secondStart = extractTime(secondText, 'Start');
+        cy.log(`Second segment Start: ${secondStart}`);
+        expect(secondStart, 'Second segment Start should be parseable').to.not.be.empty;
+        expect(secondStart,
+          `No 5-min gap: second Start (${secondStart}) should equal first End (${firstEnd})`
+        ).to.equal(firstEnd);
+      });
+    });
+    cy.pause();
+
+    cy.log('2.3 Incident tooltip Start vs alert tooltip Start vs alerts table Start');
+    incidentsPage.hoverOverIncidentBarSegment(0, 0);
+    incidentsPage.elements.tooltip().invoke('text').then((incidentText) => {
+      const incidentStart = extractTime(incidentText, 'Start');
+      cy.log(`Incident tooltip Start: ${incidentStart}`);
+      expect(incidentStart, 'Incident Start should be parseable').to.not.be.empty;
+
+      cy.log('2.4 Select incident and get alert tooltip Start');
+      incidentsPage.selectIncidentById('monitoring-multi-severity-boundary-001');
+      incidentsPage.elements.alertsChartCard().should('be.visible');
+
+      incidentsPage.hoverOverAlertBar(0);
+      incidentsPage.elements.alertsChartTooltip().invoke('text').then((alertText) => {
+        const alertStart = extractTime(alertText, 'Start');
+        cy.log(`Alert tooltip Start: ${alertStart}`);
+        expect(incidentStart,
+          `Incident Start (${incidentStart}) should match alert Start (${alertStart})`
+        ).to.equal(alertStart);
+      });
+
+      cy.log('2.5 Compare incident tooltip Start with alerts table Start');
+      incidentsPage.getSelectedIncidentAlerts().then((alerts) => {
+        expect(alerts.length, 'Should have at least 1 alert row').to.be.greaterThan(0);
+        alerts[0].getStartCell().invoke('text').then((cellText) => {
+          const tableMatch = cellText.trim().match(/(\d{1,2}:\d{2}(\s*[AP]M)?)/);
+          expect(tableMatch, 'Table Start time should be parseable').to.not.be.null;
+          const tableStart = tableMatch[1].trim();
+          cy.log(`Alerts table Start: ${tableStart}`);
+          expect(incidentStart,
+            `Incident Start (${incidentStart}) should match table Start (${tableStart})`
+          ).to.equal(tableStart);
+        });
+      });
+    });
+    cy.pause();
+
+    cy.log('Expected failure: Incident tooltip Start times are 5 minutes off (OU-1221)');
+  });
+});

web/cypress/e2e/incidents/regression/03-04.reg_e2e_firing_alerts.cy.ts

@@ -36,11 +36,13 @@ const MP = {
 describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { tags: ['@incidents', '@slow', '@e2e-real'] }, () => {
   let currentAlertName: string;
 
+
   before(() => {
     cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
 
-    cy.log('Create or reuse firing alert for testing');
-    cy.createKubePodCrashLoopingAlert('TimeBasedResolution2').then((alertName) => {
+    cy.log('Create firing alert for testing');
+    cy.cleanupIncidentPrometheusRules();
+    cy.createKubePodCrashLoopingAlert().then((alertName) => {
       currentAlertName = alertName;
       cy.log(`Test will monitor alert: ${currentAlertName}`);
     });
@@ -50,6 +52,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('1. Section 3.3 - Alert not incorrectly marked as resolved after time passes', () => {
     cy.log('1.1 Navigate to Incidents page and clear filters');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     const intervalMs = 60_000;
@@ -161,6 +164,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('2. Section 4.7 - Prometheus query end time updates to current time on filter refresh', () => {
     cy.log('2.1 Navigate to Incidents page and clear filters');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     cy.log('2.2 Capture initial page load time');
@@ -262,6 +266,7 @@ describe('Regression: Time-Based Alert Resolution (E2E with Firing Alerts)', { t
   it('3. Verify alert lifecycle - alert continues firing throughout test', () => {
     cy.log('3.1 Navigate to Incidents page');
     incidentsPage.goTo();
+    cy.wait(10000);
     incidentsPage.clearAllFilters();
 
     cy.log('3.2 Search for and select incident with custom alert');

web/cypress/e2e/incidents/regression/03.reg_api_calls.cy.ts

@@ -1,15 +1,20 @@
 /*
-Regression test for Silences Not Applied Correctly (Section 3.2)
+Regression tests for API Calls and Data Loading (Section 3)
 
-BUG: Silences were being matched by name only, not by name + namespace + severity.
-This test verifies that silence matching uses: alertname + namespace + severity.
+Tests:
+1. Silences Not Applied Correctly (Section 3.2)
+   BUG: Silences were being matched by name only, not by name + namespace + severity.
+   This test verifies that silence matching uses: alertname + namespace + severity.
 
-While targeting the bug, it verifies the basic Silences Implementation.
+2. Permission Denied Handling (Section 3.5)
+   Tests graceful handling of 403 Forbidden responses from rules/silences endpoints.
+   Incidents page should still function when user lacks permissions to view rules/silences.
 
-Verifies: OU-1020, OU-706
+Verifies: OU-1020, OU-706, OU-1213
 */
 
 import { incidentsPage } from '../../../views/incidents-page';
+import { nav } from '../../../views/nav';
 
 const MCP = {
   namespace: Cypress.env('COO_NAMESPACE'),
@@ -33,8 +38,6 @@ describe('Regression: Silences Not Applied Correctly', { tags: ['@incidents'] },
   });
 
   beforeEach(() => {
-    cy.log('Navigate to Observe → Incidents');
-    incidentsPage.goTo();
     cy.log('Setting up silenced alerts mixed scenario');
     cy.mockIncidentFixture('incident-scenarios/9-silenced-alerts-mixed-scenario.yaml');
   });
@@ -125,4 +128,39 @@ describe('Regression: Silences Not Applied Correctly', { tags: ['@incidents'] },
   });
 });
 
+describe('Regression: Permission Denied Handling', { tags: ['@incidents'] }, () => {
 
+  before(() => {
+    cy.beforeBlockCOO(MCP, MP, { dashboards: false, troubleshootingPanel: false });
+  });
+
+  beforeEach(() => {
+    cy.log('Mock all API endpoints as 403 Forbidden');
+    cy.mockPermissionDenied();
+    cy.log('Navigate to Observe -> Incidents');
+    // Using custom navigation commands to avoid waiting for the page to load which never happens in this test
+    nav.sidenav.clickNavLink(['Observe', 'Alerting']);
+    nav.tabs.switchTab('Incidents');
+
+  });
+
+  it('Page displays access denied state when all API endpoints return 403 Forbidden', () => {
+    cy.log('1.1 Verify 403 requests were intercepted');
+    const waitTimeout = { timeout: 120000 };
+    cy.wait('@rulesPermissionDenied', waitTimeout)
+      .its('response').should('exist')
+      .its('statusCode').should('eq', 403);
+    cy.wait('@silencesPermissionDenied', waitTimeout)
+      .its('response').should('exist')
+      .its('statusCode').should('eq', 403);
+    cy.wait('@prometheusQueryRangePermissionDenied', waitTimeout)
+      .its('response').should('exist')
+      .its('statusCode').should('eq', 403);
+
+    cy.log('1.2 Verify access denied empty state is displayed');
+    cy.byTestID('access-denied').should('be.visible');
+    cy.byTestID('access-denied').should('contain.text', 'You don\'t have access to this section due to cluster policy');
+
+    cy.log('Verified: Page displays restricted access state for permission denied');
+  });
+});