[COO-1562] Add ACM installation skip assertion #753
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tai-RedHat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc: @DavidRajnoha @etmurasaki, please help to review my updates, thanks! |
|
@Tai-RedHat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| cy.visit('/'); | ||
| cy.get('body', { timeout: 60000 }).should('contain.text', 'Administrator'); | ||
| // switch to Fleet Management page | ||
| cy.wait(10000); |
There was a problem hiding this comment.
Is there a not possibility to avoid the wait using some cypress conditional check here?
| failOnNonZeroExit: false, | ||
| timeout: 1200000, // long time script | ||
| }); | ||
| // enable uiplugin and add example alerts for test |
There was a problem hiding this comment.
It is out of the scope of this PR, just noting that I will probably do a refactor of this file in soon future to break it down as it again grew into bigger then manageble size.
2 participants
The test case
02.acm_alerting_ui.cywill be run via the CI job in the future; the jobrefsinclude the relevant steps for ACM installation. Therefore, assertions were added in the Cypress test.