OCPBUGS-85102: Populate status label selector for scale subresource#1497
OCPBUGS-85102: Populate status label selector for scale subresource#1497RadekManak wants to merge 2 commits intoopenshift:release-4.22from
Conversation
Uses local replace directive pointing to the cherry-picked openshift/api release-4.22 branch. Will be updated to a proper go get once the API cherry-pick merges.
Set status.labelSelector from spec.selector on each reconcile so the CRD scale subresource (labelSelectorPath: .status.labelSelector) can expose the selector string to the HPA and other autoscalers via the autoscaling/v1 Scale status.selector field. Add tests verifying calculateStatus sets labelSelector correctly and that updateMachineSetStatus writes the field even when replica counts are unchanged.
|
@RadekManak: This pull request references Jira Issue OCPBUGS-85102, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
status.labelSelectoron MachineSet so the scale subresource returns a valid selector for HPA / external autoscalersBug
https://redhat.atlassian.net/browse/OCPBUGS-85102