Skip to content

Fix IntrospectionEnabled Default, removed read only flag#1530

Open
blublinsky wants to merge 1 commit intoopenshift:mainfrom
blublinsky:MCP-AdditionalToolsets
Open

Fix IntrospectionEnabled Default, removed read only flag#1530
blublinsky wants to merge 1 commit intoopenshift:mainfrom
blublinsky:MCP-AdditionalToolsets

Conversation

@blublinsky
Copy link
Copy Markdown
Contributor

@blublinsky blublinsky commented Apr 16, 2026 •
edited
Loading

Description

Overview
This PR fixes the default behavior of the IntrospectionEnabled field, and removes the --read-only flag from the MCP server command.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci Bot requested review from joshuawilson and xrajesh April 16, 2026 17:58
@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 16, 2026

/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 16, 2026
@raptorsun
Copy link
Copy Markdown
Contributor

raptorsun commented Apr 17, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from a4ee3f0 to 70609ac Compare April 17, 2026 15:50
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026
@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 17, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026
@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 17, 2026

Holding it , until we can clarify the statements in slack thread

@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 17, 2026

/retest

1 similar comment
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 18, 2026

/retest

@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch 2 times, most recently from efc972a to d77fd11 Compare April 20, 2026 16:47
@blublinsky blublinsky changed the title Add MCP AdditionalToolsets Support & Fix IntrospectionEnabled Default Fix IntrospectionEnabled Default, removed read only flag, add observability toolset Apr 20, 2026
@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 20, 2026

@blublinsky We can just remove the readonly in this PR - lets not touch the toolset - the ticket is not asking for it . https://redhat.atlassian.net/browse/OLS-2714 will add the toolset for observability.

@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from d77fd11 to 5dfa8ba Compare April 21, 2026 08:10
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2026
@blublinsky blublinsky changed the title Fix IntrospectionEnabled Default, removed read only flag, add observability toolset Fix IntrospectionEnabled Default, removed read only flag Apr 21, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 21, 2026

/retest

@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from 5dfa8ba to 000af65 Compare April 21, 2026 11:35
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 23, 2026

/retest

@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 23, 2026

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 23, 2026

/retest

@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from 000af65 to df01960 Compare April 23, 2026 15:23
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@xrajesh
Copy link
Copy Markdown
Contributor

xrajesh commented Apr 23, 2026

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 23, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2026
@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from df01960 to ddb3d61 Compare April 24, 2026 11:47
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

New changes are detected. LGTM label has been removed.

@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented Apr 24, 2026

/retest

@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch 6 times, most recently from 96d964e to 87f2065 Compare May 1, 2026 10:33
@blublinsky blublinsky force-pushed the MCP-AdditionalToolsets branch from 87f2065 to f9cb50a Compare May 1, 2026 11:51
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented May 1, 2026

/retest

1 similar comment
@blublinsky
Copy link
Copy Markdown
Contributor Author

blublinsky commented May 4, 2026

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xrajesh
xrajesh reviewed May 6, 2026
View reviewed changes
Comment thread config/manifests/bases/lightspeed-operator.clusterserviceversion.yaml
path: llm.providers[0].googleVertexConfig.location
- description: Google Cloud project ID
displayName: Google Cloud Project ID
path: llm.providers[0].googleVertexConfig.projectID
Copy link
Copy Markdown
Contributor

@xrajesh xrajesh May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blublinsky Can this be moved out of this PR .

xrajesh
xrajesh reviewed May 6, 2026
View reviewed changes
Comment thread internal/controller/appserver/deployment_test.go

By("Disabling introspection")
cr.Spec.OLSConfig.IntrospectionEnabled = false
cr.Spec.OLSConfig.IntrospectionEnabled = utils.BoolPtr(false)
Copy link
Copy Markdown
Contributor

@xrajesh xrajesh May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a case for missing IntrospectionEnabled to verify the default case . @blublinsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrajesh xrajesh xrajesh left review comments

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees

@raptorsun raptorsun

@xrajesh xrajesh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blublinsky @xrajesh @raptorsun