Skip to content

OLS-2574: Make related_images.json the only location that defines the OLS images #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Feb 10, 2026
Merged

OLS-2574: Make related_images.json the only location that defines the OLS images #1238

openshift-merge-bot merged 1 commit into from
Feb 10, 2026
+749 −713

Conversation

@syedriko
Copy link
Contributor

@syedriko syedriko commented Jan 30, 2026

Description

Make related_images.json the only location that defines the OLS images

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2026 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-2574 which is a valid jira issue.

Details

In response to this:

Description

Make related_images.json the only location that defines the OLS images

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from raptorsun and xrajesh January 30, 2026 02:39
@syedriko
Copy link
Contributor Author

syedriko commented Jan 30, 2026

/retest

xrajesh
xrajesh reviewed Jan 30, 2026
View reviewed changes
hack/template_bundle.Containerfile Outdated
Copy link
Contributor

@xrajesh xrajesh Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedriko Are we still using this file ?

Copy link
Contributor

@raptorsun raptorsun Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is the template to generate bundle container file

raptorsun
raptorsun reviewed Jan 30, 2026
View reviewed changes
bundle.Dockerfile Outdated


FROM registry.redhat.io/ubi9/ubi-minimal:9.7
FROM registry.redhat.io/ubi9/ubi-minimal:9.6
Copy link
Contributor

@raptorsun raptorsun Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unintended downgrade

Copy link
Contributor Author

@syedriko syedriko Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@raptorsun
Copy link
Contributor

raptorsun commented Jan 30, 2026

https://github.com/openshift/lightspeed-operator/blob/main/Dockerfile#L37
we should copy the related image file into the operator container,too.

@syedriko
Copy link
Contributor Author

syedriko commented Jan 30, 2026

https://github.com/openshift/lightspeed-operator/blob/main/Dockerfile#L37 we should copy the related image file into the operator container,too.

Not sure I see what for. We normally pass the operand images to the operator on the command line at runtime, I'd rather not create another way of doing the same thing.

@raptorsun
Copy link
Contributor

raptorsun commented Feb 2, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2026
@xrajesh
Copy link
Contributor

xrajesh commented Feb 3, 2026

/approve
/override "Red Hat Konflux / console-tests-pf5 / ols-bundle"
/override "Red Hat Konflux / console-tests-pf6 / ols-bundle"

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / console-tests-pf5 / ols-bundle, Red Hat Konflux / console-tests-pf6 / ols-bundle

Details

In response to this:

/approve
/override "Red Hat Konflux / console-tests-pf5 / ols-bundle"
/override "Red Hat Konflux / console-tests-pf6 / ols-bundle"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@syedriko
Copy link
Contributor Author

syedriko commented Feb 3, 2026

/retest

1 similar comment
@syedriko
Copy link
Contributor Author

syedriko commented Feb 3, 2026

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026
@syedriko syedriko force-pushed the syedriko-ols-2574 branch 7 times, most recently from 69c2f42 to 190d5bd Compare February 4, 2026 05:25
@syedriko
Copy link
Contributor Author

syedriko commented Feb 4, 2026

/retest

raptorsun
raptorsun approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@raptorsun raptorsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@syedriko syedriko force-pushed the syedriko-ols-2574 branch 4 times, most recently from 7f32a14 to 3f0c572 Compare February 5, 2026 15:27
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2026
@syedriko syedriko force-pushed the syedriko-ols-2574 branch 2 times, most recently from fbe09a4 to a549a38 Compare February 5, 2026 22:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2026
@syedriko syedriko marked this pull request as draft February 6, 2026 06:19
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@syedriko syedriko marked this pull request as ready for review February 6, 2026 16:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@syedriko
Copy link
Contributor Author

syedriko commented Feb 6, 2026

/retest

@raptorsun
Copy link
Contributor

raptorsun commented Feb 9, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@xrajesh
Copy link
Contributor

xrajesh commented Feb 9, 2026

/approve

@xrajesh
Copy link
Contributor

xrajesh commented Feb 10, 2026

/override "Red Hat Konflux / console-tests-pf5 / ols-bundle"
/override "Red Hat Konflux / service-e2e-tests-419 / ols-bundle"

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / console-tests-pf5 / ols-bundle, Red Hat Konflux / service-e2e-tests-419 / ols-bundle

Details

In response to this:

/override "Red Hat Konflux / console-tests-pf5 / ols-bundle"
/override "Red Hat Konflux / service-e2e-tests-419 / ols-bundle"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e1eaf6b into openshift:main Feb 10, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrajesh xrajesh xrajesh left review comments

@blublinsky blublinsky Awaiting requested review from blublinsky

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@raptorsun raptorsun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@syedriko @openshift-ci-robot @raptorsun @xrajesh @openshift-merge-robot