OCPBUGS-90711: Destroy all private cluster backend service resources

[barbacbd]

When a private cluster was created, the destroy process would not find
and destroy backend services. This was happening specifically when no
backends were created/found.

Enhanced backend service discovery to check firewall rules for cluster
ID tags when backends are empty. This allows proper identification of
orphaned backend services that should be deleted during cluster destroy.

Also added global health check discovery to ensure all related resources
are properly cleaned up.

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-90711, which is invalid:

• expected Jira Issue OCPBUGS-90711 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When a private cluster was created, the destroy process would not find
and destroy backend services. This was happening specifically when no
backends were created/found.

Enhanced backend service discovery to check firewall rules for cluster
ID tags when backends are empty. This allows proper identification of
orphaned backend services that should be deleted during cluster destroy.

Also added global health check discovery to ensure all related resources
are properly cleaned up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7573631e-b8a9-4c90-9e62-9bbcef17ab13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[barbacbd]

/jira refresh

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-90711, which is invalid:

• expected dependent Jira Issue OCPBUGS-90710 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/destroy/gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[barbacbd]

/cc @tthvo

[openshift-ci]

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	54f2b74	link	true	/test images
ci/prow/e2e-gcp-ovn-xpn	54f2b74	link	false	/test e2e-gcp-ovn-xpn
ci/prow/e2e-gcp-secureboot	54f2b74	link	false	/test e2e-gcp-secureboot
ci/prow/e2e-gcp-ovn-byo-vpc	54f2b74	link	false	/test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-gcp-ovn	54f2b74	link	true	/test e2e-gcp-ovn
ci/prow/e2e-aws-ovn	54f2b74	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.