OCPBUGS-105478: [release-4.22] OCPBUGS-83799: Fix Workloads sidebar ordering when DeploymentConfig is unavailable

[kchawlani19]

Summary

• Backport of OCPBUGS-83799: Fix Workloads sidebar ordering when DeploymentConfig capability is disabled #16351 (OCPBUGS-83799) to release-4.22
• Fixes Bug: Running in-cluster and the items in Workloads tab has wrong order since 4.19 #16642: on vanilla Kubernetes / when DeploymentConfigs are disabled, Workloads nav showed StatefulSets first and pushed Topology, Pods, and Deployments to the bottom
• Root cause: statefulsets used insertAfter: "deploymentconfigs" only; when that target is filtered out the insertAfter chain breaks
• Fix: use insertAfter: ["deploymentconfigs", "deployments"] so ordering falls back to Deployments

Test plan

• On an OpenShift cluster with DeploymentConfigs available: Workloads order remains Topology → Pods → Deployments → DeploymentConfigs → StatefulSets → …
• On vanilla Kubernetes (or with DeploymentConfig capability disabled): Workloads order is Topology → Pods → Deployments → StatefulSets → Secrets → ConfigMaps → …
• Unit tests in nav/__tests__/utils.spec.ts cover the workloads insertAfter fallback scenario

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@kchawlani19: This pull request references Jira Issue OCPBUGS-83799, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-83799 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Backport of OCPBUGS-83799: Fix Workloads sidebar ordering when DeploymentConfig capability is disabled #16351 (OCPBUGS-83799) to release-4.22
• Fixes Bug: Running in-cluster and the items in Workloads tab has wrong order since 4.19 #16642: on vanilla Kubernetes / when DeploymentConfigs are disabled, Workloads nav showed StatefulSets first and pushed Topology, Pods, and Deployments to the bottom
• Root cause: statefulsets used insertAfter: "deploymentconfigs" only; when that target is filtered out the insertAfter chain breaks
• Fix: use insertAfter: ["deploymentconfigs", "deployments"] so ordering falls back to Deployments

Test plan

• On an OpenShift cluster with DeploymentConfigs available: Workloads order remains Topology → Pods → Deployments → DeploymentConfigs → StatefulSets → …
• On vanilla Kubernetes (or with DeploymentConfig capability disabled): Workloads order is Topology → Pods → Deployments → StatefulSets → Secrets → ConfigMaps → …
• Unit tests in nav/__tests__/utils.spec.ts cover the workloads insertAfter fallback scenario

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kchawlani19
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kchawlani19]

/jira cherrypick OCPBUGS-83799

[openshift-ci-robot]

@kchawlani19: Jira Issue OCPBUGS-83799 has been cloned as Jira Issue OCPBUGS-105478. Will retitle bug to link to clone.
/retitle OCPBUGS-105478: [release-4.22] OCPBUGS-83799: Fix Workloads sidebar ordering when DeploymentConfig is unavailable

Details

In response to this:

/jira cherrypick OCPBUGS-83799

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kchawlani19: This pull request references Jira Issue OCPBUGS-105478, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Backport of OCPBUGS-83799: Fix Workloads sidebar ordering when DeploymentConfig capability is disabled #16351 (OCPBUGS-83799) to release-4.22
• Fixes Bug: Running in-cluster and the items in Workloads tab has wrong order since 4.19 #16642: on vanilla Kubernetes / when DeploymentConfigs are disabled, Workloads nav showed StatefulSets first and pushed Topology, Pods, and Deployments to the bottom
• Root cause: statefulsets used insertAfter: "deploymentconfigs" only; when that target is filtered out the insertAfter chain breaks
• Fix: use insertAfter: ["deploymentconfigs", "deployments"] so ordering falls back to Deployments

Test plan

• On an OpenShift cluster with DeploymentConfigs available: Workloads order remains Topology → Pods → Deployments → DeploymentConfigs → StatefulSets → …
• On vanilla Kubernetes (or with DeploymentConfig capability disabled): Workloads order is Topology → Pods → Deployments → StatefulSets → Secrets → ConfigMaps → …
• Unit tests in nav/__tests__/utils.spec.ts cover the workloads insertAfter fallback scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@kchawlani19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/backend	5cae3db	link	true	/test backend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.