Skip to content

[release-4.22] OCPBUGS-90636: Fix RoleBindings tab error for non-cluster-admin users#16662

Open
rhamilto wants to merge 1 commit into
openshift:release-4.22from
rhamilto:OCPBUGS-90636
Open

[release-4.22] OCPBUGS-90636: Fix RoleBindings tab error for non-cluster-admin users#16662
rhamilto wants to merge 1 commit into
openshift:release-4.22from
rhamilto:OCPBUGS-90636

Conversation

@rhamilto

@rhamilto rhamilto commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Test plan

  • Log in as a non-cluster-admin user, navigate to a project's RoleBindings tab — no error should appear
  • Log in as a cluster-admin user, verify ClusterRoleBindings still appear and the "Cluster-wide RoleBindings" Kind filter works

After

localhost_9000_k8s_cluster_projects_test_roles_page=1 perPage=50

🤖 Generated with Claude Code

@rhamilto @claude
OCPBUGS-87201: Fix RoleBindings tab error for non-cluster-admin users
214e15c 
When viewing the RoleBindings tab on a project details page, the console
unconditionally fetched ClusterRoleBindings at cluster scope, causing a
"Restricted access" error for users without cluster-admin permissions.

Use an access review to check whether the user can list
ClusterRoleBindings. When the check fails (non-cluster-admin), the
ClusterRoleBinding watch is omitted, preventing the error. When the
check succeeds (cluster-admin), ClusterRoleBindings are fetched
regardless of whether a namespace is selected, preserving the
"Cluster-wide RoleBindings" Kind filter option on the list page.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-90636, which is invalid:

  • expected Jira Issue OCPBUGS-90636 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Test plan

  • Log in as a non-cluster-admin user, navigate to a project's RoleBindings tab — no error should appear
  • Log in as a cluster-admin user, verify ClusterRoleBindings still appear and the "Cluster-wide RoleBindings" Kind filter works

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto changed the title OCPBUGS-90636: Fix RoleBindings tab error for non-cluster-admin users [release-4.22] OCPBUGS-90636: Fix RoleBindings tab error for non-cluster-admin users Jun 22, 2026
@openshift-ci openshift-ci Bot requested review from TheRealJon and jhadvig June 22, 2026 16:34
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@rhamilto

rhamilto commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-90636, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-87201 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-87201 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto

rhamilto commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 22, 2026
@rhamilto

rhamilto commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

/assign @cajieh
/verified by @rhamilto

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: This PR has been marked as verified by @rhamilto.

Details

In response to this:

/assign @cajieh
/verified by @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-90636, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-87201 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-87201 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

Summary

Test plan

  • Log in as a non-cluster-admin user, navigate to a project's RoleBindings tab — no error should appear
  • Log in as a cluster-admin user, verify ClusterRoleBindings still appear and the "Cluster-wide RoleBindings" Kind filter works

After

localhost_9000_k8s_cluster_projects_test_roles_page=1 perPage=50

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@sanketpathak sanketpathak

@cajieh cajieh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @openshift-ci-robot @sanketpathak @cajieh