Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { FC, Provider as ProviderComponent, ReactNode } from 'react';
import { createContext, Suspense, useContext, useEffect } from 'react';
import { createContext, Suspense, useContext, useEffect, useMemo } from 'react';
import type { LoadedAndResolvedExtension } from '@openshift/dynamic-plugin-sdk';
import {
Button,
Expand All @@ -24,6 +24,8 @@ import {
} from '@console/dynamic-plugin-sdk';
import { applyReduxExtensions } from '@console/internal/redux';
import { LoadingBox } from '@console/shared/src/components/loading/LoadingBox';
import { ForcedPerspectiveContext } from '@console/shared/src/hooks/forcedPerspectiveContext';
import { useForcedPerspective } from '@console/shared/src/hooks/useForcedPerspective';
import { usePerspectives } from '@console/shared/src/hooks/usePerspectives';
import { useLanguage } from '../user-preferences/language/useLanguage';
import { usePreferredLanguage } from '../user-preferences/language/usePreferredLanguage';
Expand Down Expand Up @@ -148,11 +150,12 @@ export const ContextProviderExtensionWrapper: FC<{ children: ReactNode }> = ({ c
* NamespaceContext, and ContextProviderExtensionsContext.
*/
export const DetectContext: FC<{ children: ReactNode }> = ({ children }) => {
const forcedPerspective = useForcedPerspective();
const [
activePerspective,
setActivePerspective,
perspectiveLoaded,
] = useValuesForPerspectiveContext();
] = useValuesForPerspectiveContext(forcedPerspective);
const { namespace, setNamespace, loaded: namespaceLoaded } = useValuesForNamespaceContext();

const [preferredLanguage, , preferredLanguageLoaded] = usePreferredLanguage();
Expand All @@ -170,18 +173,31 @@ export const DetectContext: FC<{ children: ReactNode }> = ({ children }) => {
const location = useLocation();

useEffect(() => {
if (forcedPerspective.perspectiveId) {
if (forcedPerspective.perspectiveId !== activePerspective) {
setActivePerspective(forcedPerspective.perspectiveId, createPath(location));
}
return;
}
if (perspectiveParam && perspectiveParam !== activePerspective) {
setActivePerspective(perspectiveParam, createPath(location));
}
}, [perspectiveParam, activePerspective, setActivePerspective, location]);
}, [
forcedPerspective.perspectiveId,
perspectiveParam,
activePerspective,
setActivePerspective,
location,
]);

useEffect(() => {
if (reducersResolved) {
applyReduxExtensions(reduxReducerExtensions);
}
}, [reducersResolved, reduxReducerExtensions]);

const needsPerspectiveDetection = perspectiveLoaded && !activePerspective;
const needsPerspectiveDetection =
perspectiveLoaded && !activePerspective && !forcedPerspective.perspectiveId;
const ready =
perspectiveLoaded &&
!!activePerspective &&
Expand All @@ -190,6 +206,15 @@ export const DetectContext: FC<{ children: ReactNode }> = ({ children }) => {
providersResolved &&
preferredLanguageLoaded;

const perspectiveContextValue = useMemo(() => ({ activePerspective, setActivePerspective }), [
activePerspective,
setActivePerspective,
]);
const namespaceContextValue = useMemo(() => ({ namespace, setNamespace }), [
namespace,
setNamespace,
]);

if (!ready) {
const pending: string[] = [];
if (!perspectiveLoaded) pending.push('Perspective');
Expand All @@ -210,12 +235,14 @@ export const DetectContext: FC<{ children: ReactNode }> = ({ children }) => {
}

return (
<PerspectiveContext.Provider value={{ activePerspective, setActivePerspective }}>
<NamespaceContext.Provider value={{ namespace, setNamespace }}>
<ContextProviderExtensionsContext.Provider value={contextProviderExtensions}>
{children}
</ContextProviderExtensionsContext.Provider>
</NamespaceContext.Provider>
</PerspectiveContext.Provider>
<ForcedPerspectiveContext.Provider value={forcedPerspective}>
<PerspectiveContext.Provider value={perspectiveContextValue}>
<NamespaceContext.Provider value={namespaceContextValue}>
<ContextProviderExtensionsContext.Provider value={contextProviderExtensions}>
{children}
</ContextProviderExtensionsContext.Provider>
</NamespaceContext.Provider>
</PerspectiveContext.Provider>
</ForcedPerspectiveContext.Provider>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import { usePreferredPerspective } from '../../user-preferences/perspective/useP
import { useLastPerspective } from '../useLastPerspective';
import { useValuesForPerspectiveContext } from '../useValuesForPerspectiveContext';

const noForcedPerspective = { loaded: true, perspectiveId: null };

jest.mock('@console/shared/src/hooks/usePerspectives', () => ({
usePerspectiveExtension: jest.fn(),
usePerspectives: jest.fn(),
Expand Down Expand Up @@ -44,7 +46,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['foo', jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue([undefined, jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
const { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
const { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
const [perspective] = result.current;
expect(perspective).toBe('');
});
Expand All @@ -54,7 +58,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['dev', jest.fn(), false]);
usePreferredPerspectiveMock.mockReturnValue(['admin', jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
let { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
let { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
let [perspective, , loaded] = result.current;
expect(perspective).toBe('');
expect(loaded).toBeFalsy();
Expand All @@ -65,7 +71,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['dev', jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue(['admin', jest.fn(), false]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
({ result } = renderHookWithProviders(() => useValuesForPerspectiveContext()));
({ result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
));
[perspective, , loaded] = result.current;
expect(perspective).toBe('');
expect(loaded).toBeFalsy();
Expand All @@ -76,7 +84,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['dev', jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue(['admin', jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
const { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
const { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
const [perspective] = result.current;
expect(perspective).toEqual('admin');
});
Expand All @@ -86,7 +96,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['dev', jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue([undefined, jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
const { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
const { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
const [perspective] = result.current;
expect(perspective).toEqual('dev');
});
Expand All @@ -96,7 +108,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue(['dev', jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue(['dev', jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
const { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
const { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
const [perspective] = result.current;
expect(perspective).toEqual('dev');
});
Expand All @@ -106,7 +120,9 @@ describe('useValuesForPerspectiveContext', () => {
useLastPerspectiveMock.mockReturnValue([undefined, jest.fn(), true]);
usePreferredPerspectiveMock.mockReturnValue([undefined, jest.fn(), true]);
usePerspectiveExtensionMock.mockReturnValue(acmPerspectiveExtension);
const { result } = renderHookWithProviders(() => useValuesForPerspectiveContext());
const { result } = renderHookWithProviders(() =>
useValuesForPerspectiveContext(noForcedPerspective),
);
const [perspective] = result.current;
expect(perspective).toEqual(ACM_PERSPECTIVE_ID);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@ import {
usePerspectives,
} from '@console/shared/src/hooks/usePerspectives';
import { useTelemetry } from '@console/shared/src/hooks/useTelemetry';
import type { ForcedPerspectiveResult } from '@console/shared/src/utils/forcedPerspective';
import { ACM_PERSPECTIVE_ID } from '../../consts';
import { usePreferredPerspective } from '../user-preferences/perspective/usePreferredPerspective';
import { useLastPerspective } from './useLastPerspective';

type SetActivePerspective = ReturnType<UseActivePerspective>[1];

export const useValuesForPerspectiveContext = (): [
PerspectiveType,
SetActivePerspective,
boolean,
] => {
export const useValuesForPerspectiveContext = (
forcedPerspective: ForcedPerspectiveResult,
): [PerspectiveType, SetActivePerspective, boolean] => {
const navigate = useNavigate();
const fireTelemetryEvent = useTelemetry();
const perspectiveExtensions = usePerspectives();
Expand All @@ -32,7 +31,13 @@ export const useValuesForPerspectiveContext = (): [
? ACM_PERSPECTIVE_ID
: existingPerspective || '';
const isValidPerspective =
loaded && perspectiveExtensions.some((p) => p.properties.id === perspective);
(loaded && perspectiveExtensions.some((p) => p.properties.id === perspective)) ||
!!forcedPerspective.perspectiveId;
const resolvedPerspective = forcedPerspective.perspectiveId
? forcedPerspective.perspectiveId
: isValidPerspective
? perspective
: '';

const setPerspective = useCallback<SetActivePerspective>(
(newPerspective, next) => {
Expand All @@ -45,5 +50,5 @@ export const useValuesForPerspectiveContext = (): [
[setLastPerspective, setActivePerspective, navigate, fireTelemetryEvent],
);

return [isValidPerspective ? perspective : '', setPerspective, loaded];
return [resolvedPerspective, setPerspective, loaded];
};
62 changes: 41 additions & 21 deletions frontend/packages/console-app/src/components/nav/NavHeader.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
import type { FC, MouseEvent, Ref } from 'react';
import { useMemo, useState, useCallback } from 'react';
import type { MenuToggleElement } from '@patternfly/react-core';
import { MenuToggle, Select, SelectList, SelectOption, Title } from '@patternfly/react-core';
import { RhUiGearGroupFillIcon } from '@patternfly/react-icons';
import { useTranslation } from 'react-i18next';
import {
MenuToggle,
Select,
SelectList,
SelectOption,
Title,
Skeleton,
} from '@patternfly/react-core';
import type { Perspective } from '@console/dynamic-plugin-sdk';
import { useActivePerspective } from '@console/dynamic-plugin-sdk';
import { AsyncComponent } from '@console/internal/components/utils/async';
import { useForcedPerspectiveContext } from '@console/shared/src/hooks/forcedPerspectiveContext';
import { usePerspectives } from '@console/shared/src/hooks/usePerspectives';

type NavHeaderProps = {
Expand All @@ -22,6 +28,18 @@ type PerspectiveDropdownItemProps = {

const IconLoadingComponent: FC = () => <>&emsp;</>;

const PerspectiveIcon: FC<{
icon?: Perspective['properties']['icon'];
}> = ({ icon }) =>
icon ? (
<AsyncComponent
loader={() => icon().then((m) => m.default)}
LoadingComponent={IconLoadingComponent}
/>
) : (
<Skeleton />
);

const PerspectiveDropdownItem: FC<PerspectiveDropdownItemProps> = ({ perspective, onClick }) => {
return (
<SelectOption
Expand All @@ -31,12 +49,7 @@ const PerspectiveDropdownItem: FC<PerspectiveDropdownItemProps> = ({ perspective
e.preventDefault();
onClick(perspective.properties.id);
}}
icon={
<AsyncComponent
loader={() => perspective.properties.icon().then((m) => m.default)}
LoadingComponent={IconLoadingComponent}
/>
}
icon={<PerspectiveIcon icon={perspective.properties.icon} />}
>
<Title headingLevel="h2" size="md">
{perspective.properties.name}
Expand All @@ -49,7 +62,13 @@ const NavHeader: FC<NavHeaderProps> = ({ onPerspectiveSelected }) => {
const [activePerspective, setActivePerspective] = useActivePerspective();
const [isPerspectiveDropdownOpen, setPerspectiveDropdownOpen] = useState(false);
const perspectiveExtensions = usePerspectives();
const { t } = useTranslation('console-app');
const forcedPerspective = useForcedPerspectiveContext();
const displayedPerspective = useMemo(() => {
const targetId = forcedPerspective.perspectiveId || activePerspective;
return (
perspectiveExtensions.find((p) => p?.properties?.id === targetId) ?? perspectiveExtensions[0]
);
}, [forcedPerspective.perspectiveId, activePerspective, perspectiveExtensions]);

const togglePerspectiveOpen = useCallback(() => {
setPerspectiveDropdownOpen((isOpen) => !isOpen);
Expand Down Expand Up @@ -80,7 +99,7 @@ const NavHeader: FC<NavHeaderProps> = ({ onPerspectiveSelected }) => {
[activePerspective, perspectiveExtensions],
);

return perspectiveDropdownItems.length > 1 ? (
return perspectiveDropdownItems.length > 1 && !forcedPerspective.perspectiveId ? (
<div
className="oc-nav-header"
data-tour-id="tour-perspective-dropdown"
Expand All @@ -97,14 +116,7 @@ const NavHeader: FC<NavHeaderProps> = ({ onPerspectiveSelected }) => {
isExpanded={isPerspectiveDropdownOpen}
ref={toggleRef}
onClick={() => togglePerspectiveOpen()}
icon={
icon && (
<AsyncComponent
loader={() => icon().then((m) => m.default)}
LoadingComponent={IconLoadingComponent}
/>
)
}
icon={<PerspectiveIcon icon={icon ?? undefined} />}
>
{name && (
<Title headingLevel="h2" size="md">
Expand All @@ -121,9 +133,17 @@ const NavHeader: FC<NavHeaderProps> = ({ onPerspectiveSelected }) => {
</Select>
</div>
) : (
<div data-test-id="perspective-switcher-toggle" id="core-platform-perspective">
<div
data-test-id="perspective-switcher-toggle"
id={
forcedPerspective.perspectiveId ||
displayedPerspective?.properties?.id ||
'core-platform-perspective'
}
>
<Title headingLevel="h2" size="md">
<RhUiGearGroupFillIcon /> {t('Core platform')}
<PerspectiveIcon icon={displayedPerspective?.properties?.icon} />{' '}
{displayedPerspective?.properties?.name ?? <Skeleton />}
</Title>
</div>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { FC } from 'react';
import { useCallback, useState, useEffect, useMemo } from 'react';
import { memo, useCallback, useMemo } from 'react';
import { NavList } from '@patternfly/react-core';
import type { DragDropSortProps, DraggableObject } from '@patternfly/react-drag-drop';
import { DragDropSort } from '@patternfly/react-drag-drop';
Expand All @@ -18,18 +18,15 @@ import { getSortedNavExtensions, isTopLevelNavItem } from './utils';

import './PerspectiveNav.scss';

const PerspectiveNav: FC<{}> = () => {
const PerspectiveNav: FC = () => {
const [activePerspective] = useActivePerspective();
const allNavExtensions = useNavExtensionsForPerspective(activePerspective);
const [pinnedResources, setPinnedResources, pinnedResourcesLoaded] = usePinnedResources();
const [validPinnedResources, setValidPinnedResources] = useState<string[]>([]);
const validPinnedResources = useMemo(() => pinnedResources.filter((res) => !!modelFor(res)), [
pinnedResources,
]);
const { t } = useTranslation('console-app');

useEffect(() => {
const validResources = pinnedResources.filter((res) => !!modelFor(res));
setValidPinnedResources(validResources);
}, [setValidPinnedResources, pinnedResources]);

const orderedNavExtensions = useMemo(() => {
const topLevelNavExtensions = allNavExtensions.filter(isTopLevelNavItem);
return getSortedNavExtensions(topLevelNavExtensions);
Expand Down Expand Up @@ -98,4 +95,4 @@ const PerspectiveNav: FC<{}> = () => {
);
};

export default PerspectiveNav;
export default memo(PerspectiveNav);
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,16 @@ jest.mock('@console/internal/components/utils/async', () => ({
AsyncComponent: () => null,
}));

jest.mock('@console/shared/src/hooks/forcedPerspectiveContext', () => ({
useForcedPerspectiveContext: jest.fn(() => ({ loaded: true, perspectiveId: null })),
}));

describe('NavHeader', () => {
const mockOnPerspectiveSelected = jest.fn();
let mockSetActivePerspective: jest.Mock;

beforeEach(() => {
window.localStorage.clear();
jest.clearAllMocks();
mockSetActivePerspective = jest.fn();
});
Expand Down
Loading