OCPBUGS-74647: Fix referenceFor parameter in SubscriptionDetailsPage

[rhamilto]

After

Summary

• Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage
• Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

• Verify that the Subscription details page loads correctly
• Verify that the action menu on the Subscription details page functions properly
• Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed subscription action menu context handling to correctly reference individual objects, improving functionality and reliability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-74647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage
• Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

• Verify that the Subscription details page loads correctly
• Verify that the action menu on the Subscription details page functions properly
• Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-74647, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

After

Summary

• Fixed incorrect parameter passed to referenceFor function in SubscriptionDetailsPage
• Changed from kindObj to obj to align with proper referenceFor usage pattern

Details

In the customActionMenu prop of SubscriptionDetailsPage, the referenceFor function was being called with kindObj instead of obj. The referenceFor utility expects a resource object, not a kind/model object, so this change ensures the correct parameter is passed.

Test plan

• Verify that the Subscription details page loads correctly
• Verify that the action menu on the Subscription details page functions properly
• Check that the correct context is passed to LazyActionMenu

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/cherrypick release-4.21 release-4.20

[openshift-cherrypick-robot]

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21 release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The LazyActionMenu context key derivation in the subscription table row component has been updated to reference the actual subscription object instead of the kind model. The context mapping now uses referenceFor(obj) as the key rather than referenceFor(kindObj), ensuring the action menu operates with the specific object instance. No changes to control flow or surrounding logic are introduced.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title references fixing the referenceFor parameter in SubscriptionDetailsPage, which matches the core change: using referenceFor(obj) instead of referenceFor(kindObj) in SubscriptionTableRow's LazyActionMenu.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jhadvig]

Nice catch @rhamilto 🫡
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [jhadvig,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/retest

[rhamilto]

/retest

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhamilto]

/assign @yapei