Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jan 27, 2026

  • Remove label, helpText, helpTextInvalid from FieldProps because it's not common to all fields
  • Remove hideContents as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature
  • Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
  • Align co-required style with PF
  • DroppableFileInput is now under the PF form ecosystem instead of the legacy one. That means that to use DroppableFileInput in a legacy form, you'll have to wrap it in a pf-v6-c-form for proper styling of the form group label

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2026

@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Remove label, helpText, helpTextInvalid from FieldProps because it's not common to all fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rhamilto and sg00dwin January 27, 2026 15:47
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jan 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cypress Related to Cypress e2e integration testing labels Jan 27, 2026
@logonoff logonoff force-pushed the CONSOLE-5015-file-input branch from b242ead to 4f2d07b Compare January 27, 2026 18:57
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 27, 2026
@logonoff logonoff force-pushed the CONSOLE-5015-file-input branch 2 times, most recently from 01dbae5 to 7cfc3b6 Compare January 30, 2026 14:50
- Remove `label`, `helpText`, `helpTextInvalid` from `FieldProps` because it's not common to all fields
- Remove `hideContents` as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature
- Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
- Align `co-required` style with PF
@logonoff logonoff force-pushed the CONSOLE-5015-file-input branch from 7cfc3b6 to 812b830 Compare January 30, 2026 21:17
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2026

@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Remove label, helpText, helpTextInvalid from FieldProps because it's not common to all fields
  • Remove hideContents as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature
  • Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
  • Align co-required style with PF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/assign @rhamilto

@logonoff
Copy link
Member Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 30, 2026
@logonoff
Copy link
Member Author

/assign @yapei

@logonoff logonoff changed the title CONSOLE-5015: Refactor file-input to use PF (WIP) CONSOLE-5015: Refactor file-input to use PF Jan 30, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2026

@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Remove label, helpText, helpTextInvalid from FieldProps because it's not common to all fields
  • Remove hideContents as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature
  • Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
  • Align co-required style with PF
  • DroppableFileInput is now under the PF form ecosystem instead of the form-group one. That means that to use DroppableFileInput in a legacy form, you'll have to wrap it in a pf-v6-c-form for proper styling of the form group label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2026

@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Remove label, helpText, helpTextInvalid from FieldProps because it's not common to all fields
  • Remove hideContents as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature
  • Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
  • Align co-required style with PF
  • DroppableFileInput is now under the PF form ecosystem instead of the legacy one. That means that to use DroppableFileInput in a legacy form, you'll have to wrap it in a pf-v6-c-form for proper styling of the form group label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants