Fix make build target cd issue

[jrangelramos]

Fix make build target error

$ make build       
hack/build-go.sh
hack/build-go.sh: line 6: cd: null directory
make: *** [Makefile:5: build] Error 1

Summary by CodeRabbit

• Chores
  • Minor build script improvements to ensure proper repository directory navigation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a6f24b1e-7043-413c-a108-a87655b19289

📥 Commits

Reviewing files that changed from the base of the PR and between 810bfc1 and 0907045.

📒 Files selected for processing (1)

• hack/build-go.sh

---

Walkthrough

The build script hack/build-go.sh has been modified to append ./ to the repository root path computed by git rev-parse --show-cdup during the directory change operation.

Changes

Build Script Repository Navigation

Layer / File(s)	Summary
Repository root navigation fix hack/build-go.sh	The cd command now appends ./ to the path from git rev-parse --show-cdup for repository root navigation.

---

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing a cd (change directory) issue in the make build target, which aligns with the PR's objective of resolving the 'cd: null directory' failure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR #1404 changes only hack/build-go.sh (cd path fix). No Ginkgo It/Describe/Context/When titles are added or modified, so no nondeterministic test names are introduced.
Test Structure And Quality	✅ Passed	PR #1404 changes only hack/build-go.sh (cd path). No Ginkgo test files/code were modified, so the Ginkgo quality requirements are not applicable here.
Microshift Test Compatibility	✅ Passed	PR #1404 changes only hack/build-go.sh (cd "$(git rev-parse --show-cdup)./"); no new/modified Ginkgo e2e tests to evaluate for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR #1404 changes only hack/build-go.sh (1 file); no new/modified Ginkgo e2e tests are introduced, so SNO compatibility assumptions can’t be implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes hack/build-go.sh only: it just tweaks repo-root cd (cd "$(git rev-parse --show-cdup)./"); no manifests/controllers/scheduling constraints added.
Ote Binary Stdout Contract	✅ Passed	PR changes only hack/build-go.sh (cd path fix); OTE binary main (cmd/cluster-version-operator-tests/main.go) has no fmt.Print/Println/Printf/log/klog stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR #1404 changes only hack/build-go.sh (cd "$(git rev-parse --show-cdup)./"); no new/modified Ginkgo e2e tests, so no IPv6/disconnected networking assumptions to flag.
No-Weak-Crypto	✅ Passed	PR changes only hack/build-go.sh; scanning that file shows no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or non-constant-time secret/token comparisons.
Container-Privileges	✅ Passed	Only hack/build-go.sh changed (git diff origin/main..HEAD --name-only lists 1 file); no container/K8s manifests or privilege settings (hostPID/hostNetwork/allowPrivilegeEscalation/etc.) were modified.
No-Sensitive-Data-In-Logs	✅ Passed	PR 1404 only updates the cd command in hack/build-go.sh; it does not add any logging that would expose passwords/tokens/API keys/PII/internal hostnames.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign fao89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jrangelramos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	0907045	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn-techpreview-serial-1of3	0907045	link	true	/test e2e-agnostic-ovn-techpreview-serial-1of3
ci/prow/e2e-agnostic-ovn-upgrade-into-change	0907045	link	true	/test e2e-agnostic-ovn-upgrade-into-change
ci/prow/e2e-agnostic-ovn-techpreview-serial-3of3	0907045	link	true	/test e2e-agnostic-ovn-techpreview-serial-3of3
ci/prow/e2e-hypershift	0907045	link	true	/test e2e-hypershift
ci/prow/e2e-agnostic-ovn	0907045	link	true	/test e2e-agnostic-ovn
ci/prow/e2e-agnostic-ovn-techpreview-serial-2of3	0907045	link	true	/test e2e-agnostic-ovn-techpreview-serial-2of3
ci/prow/e2e-hypershift-conformance	0907045	link	true	/test e2e-hypershift-conformance
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change	0907045	link	true	/test e2e-agnostic-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.