OCPBUGS-105409: chore: remove AWSServiceLBNetworkSecurityGroup feature gate references - #500
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughManaged NLB security groups are now always configured in ChangesManaged NLB security groups
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold |
openshift-ci
Bot
added
do-not-merge/hold
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pkg/cloud/aws/aws_config_transformer_test.go (1)
53-54: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd coverage for an existing non-Managed mode.
All current inputs omit
NLBSecurityGroupMode, so these cases exercise only the empty-value path. Add a fixture with a non-Managed value and assert that the serialized output isNLBSecurityGroupMode = Managed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/cloud/aws/aws_config_transformer_test.go` around lines 53 - 54, Extend the AWS CloudConfig transformation test fixtures to include an explicit non-Managed NLBSecurityGroupMode input, and assert that serialization outputs NLBSecurityGroupMode = Managed. Preserve the existing empty-value cases while adding coverage for this normalization behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift-tests/ccm-aws-tests/e2e/aws/loadbalancer.go`:
- Around line 48-51: Update the assertion description for the
NLBSecurityGroupMode test to remove the outdated feature-gate condition and
state only that NLBSecurityGroupMode must be set to “Managed” in cloud-config.
Keep the test behavior unchanged.
---
Nitpick comments:
In `@pkg/cloud/aws/aws_config_transformer_test.go`:
- Around line 53-54: Extend the AWS CloudConfig transformation test fixtures to
include an explicit non-Managed NLBSecurityGroupMode input, and assert that
serialization outputs NLBSecurityGroupMode = Managed. Preserve the existing
empty-value cases while adding coverage for this normalization behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6acfa20b-1be5-4ea8-b293-308346418160
📒 Files selected for processing (8)
docs/dev/e2e-ote-ccm-aws.mdopenshift-tests/README.mdopenshift-tests/ccm-aws-tests/e2e/aws/helper.goopenshift-tests/ccm-aws-tests/e2e/aws/loadbalancer.goopenshift-tests/ccm-aws-tests/e2e/common/helper.gopkg/cloud/aws/aws_config_transformer.gopkg/cloud/aws/aws_config_transformer_test.gopkg/controllers/cloud_config_sync_controller_test.go
💤 Files with no reviewable changes (2)
- openshift-tests/README.md
- openshift-tests/ccm-aws-tests/e2e/aws/helper.go
The AWSServiceLBNetworkSecurityGroup feature gate has been promoted to GA and is always enabled. Remove the feature gate check from the AWS cloud config transformer so NLBSecurityGroupMode=Managed is set unconditionally, and clean up related tests and docs. Test names containing the feature gate are preserved for component readiness reporting stability.
93759df to
efdc348
Compare
|
/assign @mtulio @mfbonfigli |
|
/lgtm |
|
/approve |
|
/retest |
|
Thanks for handling that, @damdo . |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
/approve
based on @mtulio and @mfbonfigli 's feedback
|
/verified by ci |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, mfbonfigli, mtulio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
verified
|
@damdo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
damdo
changed the title
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci-robot
added
the
jira/invalid-bug
|
@damdo: This pull request references Jira Issue OCPBUGS-105409, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/jira refresh |
|
@damdo: This pull request references Jira Issue OCPBUGS-105409, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@damdo: This pull request references Jira Issue OCPBUGS-105409, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@damdo: Jira Issue OCPBUGS-105409: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-105409 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Summary
AWSServiceLBNetworkSecurityGroupfeature gate check from the AWS cloud config transformer —NLBSecurityGroupMode=Managedis now set unconditionallyisFeatureGateEnabledhelper function (no longer used)[OCPFeatureGate:AWSServiceLBNetworkSecurityGroup]are preserved for component readiness reporting stabilityTest plan
go test ./pkg/cloud/aws/...passesgo build ./pkg/...compiles successfullyAWSServiceLBNetworkSecurityGroupremain (only test names and their constant)Related
Summary by CodeRabbit
New Features
Bug Fixes
Documentation