Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simkam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
686cda5 to
307b73f
Compare
|
/hold ongoing discussion |
|
/hold cancel |
| @@ -0,0 +1,17 @@ | |||
| to: 4.22.9 | |||
| from: .* | |||
| url: https://redhat.atlassian.net/browse/OCPBUGS-121207 | |||
There was a problem hiding this comment.
we usually point at the impact statement ticket, in this case OTA-2119, and not at the OCPBUGS. Reasons include:
- The OCPBUGS is often written from a reporter to the component developer, to help them understand what's broken, so they can work up a fix. In this case, with OCPBUGS-121207, I'm not sure what the fix would be. 4.22.10 has already shipped, so there's no change to make in the shipped product, right? The impact statement, on the other hand, is written to the cluster admin considering an update into an impacted release. So it can cover things like "How involved is remediation?" that a cluster-admin likely cares about, but which a developer trying to fix a bug likely does not care about.
- OCPBUGS are tied to a specific target release, and one issue impacting multiple branches will have a separate OCPBUGS tracking a backport into each branch. Impact statements can talk about the issue as it impacts updates, without being pinned to a single target release branch.
| - type: PromQL | ||
| promql: | ||
| promql: | | ||
| group by (_id) (csv_succeeded{_id="",name=~"portworx-operator[.]v.*"}) |
There was a problem hiding this comment.
It doesn't impact cluster-version operator functionality, but personally, I find this kind of PromQL easier to debug if we keep name around instead of group aggregating it away. This is a recent example
Clusters running Portworx may lose storage after upgrading to 4.22.9. The RHCOS kernel (5.14.0-687.35.1.el9_8) shipped with that version is missing from RHEL package repositories, preventing Portworx from building its kernel module. Spike: https://redhat.atlassian.net/browse/OTA-2119 Bug: https://redhat.atlassian.net/browse/OCPBUGS-121207 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
307b73f to
317e078
Compare
|
@simkam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Clusters running Portworx may lose storage after upgrading to 4.22.9. The RHCOS kernel (5.14.0-687.35.1.el9_8) shipped with that version is missing from RHEL package repositories, preventing Portworx from building its kernel module.
Spike: https://redhat.atlassian.net/browse/OTA-2119
Bug: https://redhat.atlassian.net/browse/OCPBUGS-121207