minor updates#8
Open
codekow wants to merge 12 commits intoopenshift:mainfrom
Open
Conversation
sdodson
requested changes
May 5, 2026
Member
sdodson
left a comment
sdodson
left a comment
There was a problem hiding this comment.
Needs a rebase, also I would prefer if the manifests were in a directory named manifests which is more inline with the norms for most OpenShift repo layouts, do you mind doing that?
I'm also not sure if we want to go with the build option. It should at least be a choice, either use a pre-built signed image from Red Hat or pursue the buildconfig option. Some clusters don't have an Cluster Image Registry enabled.
Author
|
Good feedback. I'll make some adjustments. |
codekow
force-pushed
the
updates
branch
2 times, most recently
from
b8f9b1c to
76e83bc
Compare
Author
|
Once this PR / refactor has happened I will create kustomized overlays that allow you to use a build config or not. @sdodson Does that work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.