SPLAT-2588 / WIP: Removing hypershift gates for AWSServiceLBNetworkSecurityGroup

[mtulio]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @mtulio! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mtulio]

/test ?

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0da626a4-6aec-4c41-acd6-1c9142238deb

📥 Commits

Reviewing files that changed from the base of the PR and between 047c895 and 879a92c.

📒 Files selected for processing (8)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (1)

• features/features.go

---

📝 Walkthrough

Walkthrough

The pull request modifies feature gate configuration across multiple deployment environments and release channels. The AWSServiceLBNetworkSecurityGroup feature gate is transitioning from enabled to disabled status in YAML manifest files for Hypershift and SelfManagedHA deployments, including DevPreviewNoUpgrade, TechPreviewNoUpgrade, and OKD channels. The features.md documentation table is updated to reflect the feature gate as disabled across all environments. The features/features.go file contains stray numeric lines that appear to introduce syntax errors preventing successful compilation.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name	Status	Explanation	Resolution
Ote Binary Stdout Contract	❌ Error	PR adds tools/publish-kubebuilder-tools/main.go with two fmt.Printf() calls writing to stdout in main(). This violates OTE Binary Stdout Contract requirement for JSON-only stdout.	Redirect fmt.Printf calls to stderr with fmt.Fprintf(os.Stderr, ...) or remove them from process-level code.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the purpose, scope, and motivation for removing the Hypershift gates for AWSServiceLBNetworkSecurityGroup.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: removing Hypershift gates for AWSServiceLBNetworkSecurityGroup, which aligns with the documented changes across multiple feature gate manifests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test files are modified in this PR. The check for stable and deterministic test names is not applicable to changes in features.md, features/features.go, and YAML configuration files.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo test code changes. The custom check requires reviewing Ginkgo test quality, which is not applicable here. Changes are to documentation and manifests only.
Microshift Test Compatibility	✅ Passed	This PR adds no new Ginkgo e2e tests. Changes are limited to feature gate configuration and manifests, making the MicroShift test compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies feature gate configuration files and documentation. The SNO test compatibility check is not applicable to this PR.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only feature gate configuration changes, no deployment manifests, operator code, or scheduling constraints. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds Ginkgo tests using envtest (local test cluster), not e2e tests. The check applies only to e2e tests that run against real clusters. Local unit/integration tests are not in scope.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@mtulio: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance

[mtulio]

/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance

[openshift-ci]

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	879a92c	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-hypershift-conformance	879a92c	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.