Remove NodeSelector and Tolerations from NodeExporterConfig

[danielmellado]

Node-exporter runs as a DaemonSet that must run on all nodes, so
nodeSelector and tolerations fields are not meaningful for it.

This PR removesthese fields from the CRD API along with their
associated tests.

Signed-off-by: Daniel Mellado dmellado@fedoraproject.org

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @danielmellado! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c4192c67-92df-4589-97c4-d4e7681acac7

📥 Commits

Reviewing files that changed from the base of the PR and between 2955bfa and 1f02d69.

⛔ Files ignored due to path filters (5)

• config/v1alpha1/zz_generated.crd-manifests/0000_10_config-operator_01_clustermonitorings.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1alpha1/zz_generated.deepcopy.go is excluded by !**/zz_generated*
• config/v1alpha1/zz_generated.featuregated-crd-manifests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*

📒 Files selected for processing (3)

• config/v1alpha1/tests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml
• config/v1alpha1/types_cluster_monitoring.go
• payload-manifests/crds/0000_10_config-operator_01_clustermonitorings.crd.yaml

💤 Files with no reviewable changes (3)

• config/v1alpha1/tests/clustermonitorings.config.openshift.io/ClusterMonitoringConfig.yaml
• payload-manifests/crds/0000_10_config-operator_01_clustermonitorings.crd.yaml
• config/v1alpha1/types_cluster_monitoring.go

---

📝 Walkthrough

Walkthrough

Updates are made to the ClusterMonitoringConfig CRD and related test suite, specifically targeting the NodeExporterConfig section. The YAML test file is modified to adjust test expectations around the resources block structure. The CRD manifest documentation is updated to reflect revised default values for nodeExporterConfig.resources CPU and memory requests, and the tolerations field description is modified to describe empty defaults when omitted rather than the previous "tolerate all taints" behavior. The Go types file contains only non-semantic adjustments. Overall functionality and schema structure remain unchanged.

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly summarizes the main change: removing NodeSelector and Tolerations from NodeExporterConfig, which aligns with the primary modifications across the test file, Go types file, and CRD manifest.
Description check	✅ Passed	The description is related to the changeset, explaining the rationale for removing NodeSelector and Tolerations fields from NodeExporterConfig and mentioning deletion of associated tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names are static and deterministic. No dynamic suffixes, timestamps, UUIDs, or IP addresses in test titles. Test names are descriptive and indicate what is tested.
Test Structure And Quality	✅ Passed	Removed tests follow proper structure with single responsibility and meaningful error messages. Test removal matches deleted API fields.
Microshift Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests. It modifies CRD validation test suites (envtest framework), API types, and CRD manifests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests. It only removes test cases from a CRD validation file and modifies API type definitions. The check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR removes nodeSelector and tolerations from NodeExporterConfig. No topology-unaware scheduling constraints are introduced. DaemonSet runs on all nodes automatically.
Ote Binary Stdout Contract	✅ Passed	PR modifies API schema definitions and test data only. No executable code added. No stdout writes that could violate OTE contract detected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies YAML CRD validation tests and Go type definitions. The custom check for IPv6/disconnected network compatibility is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danielmellado]

@everettraven CI failures are expected as per the 'NoFieldRemoval', we'd need to override that, thanks in advance!

[openshift-ci]

@danielmellado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-crdify	1f02d69	link	true	/test verify-crdify
ci/prow/verify-crd-schema	1f02d69	link	true	/test verify-crd-schema

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.