CNV-93096: Fix wrong condition for the CPUManager feature gate by nunnatsa · Pull Request #321 · openshift-virtualization/virt-platform-autopilot

nunnatsa · 2026-08-19T13:28:21Z

The CPUManager is not HCO's feature gate, but KubeVirt's.

Added new condition type for KV FGs, and use it to replace the existing
condition for kubelet-cpu-manager.

github-actions · 2026-08-19T13:29:01Z

❌ Generated Files Verification Failed

One or more generated files in this PR are out of sync:

CRDs: Run make update-crds if CRD verification failed
RBAC: Run make generate-rbac if RBAC verification failed

Please regenerate the files locally and commit the changes.

openshift-ci · 2026-08-19T13:29:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign machadovilaca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-08-20T07:17:52Z

❌ Generated Files Verification Failed

One or more generated files in this PR are out of sync:

CRDs: Run make update-crds if CRD verification failed
RBAC: Run make generate-rbac if RBAC verification failed

Please regenerate the files locally and commit the changes.

github-actions · 2026-08-20T10:03:48Z

❌ Generated Files Verification Failed

One or more generated files in this PR are out of sync:

CRDs: Run make update-crds if CRD verification failed
RBAC: Run make generate-rbac if RBAC verification failed

Please regenerate the files locally and commit the changes.

github-actions · 2026-08-20T10:09:32Z

❌ Generated Files Verification Failed

One or more generated files in this PR are out of sync:

CRDs: Run make update-crds if CRD verification failed
RBAC: Run make generate-rbac if RBAC verification failed

Please regenerate the files locally and commit the changes.

tiraboschi · 2026-08-20T13:07:25Z

 | `pci-passthrough` | | MachineConfig | Opt-in: hardware + annotation condition |
 | `kubelet-perf-settings` | | KubeletConfig | Always-on baseline |
-| `kubelet-cpu-manager` | | KubeletConfig | Opt-in: CPUManager feature gate |
+| `kubelet-cpu-manager` | | KubeletConfig | Always-on baseline |


Opt-in: CPUManager KubeVirt feature gate (on by default) ?

tiraboschi · 2026-08-20T13:09:40Z

@@ -0,0 +1,42 @@
+package resources


please add copyright header

tiraboschi · 2026-08-20T13:09:46Z

@@ -0,0 +1,235 @@
+package resources_test


tiraboschi · 2026-08-20T13:10:41Z

 	rules := StaticRules()
-	if len(rules) != 8 {
+	if len(rules) != 9 {
 		t.Errorf("expected 8 static rules, got %d", len(rules))


now 9 also in the error message (or make it dynamic for the future).

tiraboschi · 2026-08-20T13:11:42Z

+	Topology             *TopologyContext           // Cluster topology info (HCP, compact, node counts)
+	Images               map[string]string          // Container images from RELATED_IMAGE_* env vars
+	Params               map[string]string          // Per-asset parameters from metadata template_params
+	KubeVirtFeatureGates []string                   // Full KubeVirt object, templates access directly


now just the FG list

tiraboschi · 2026-08-20T13:18:37Z

@@ -0,0 +1 @@
+../../../assets


I don't really like the symlink approach, I think it could become fragile. Can we avoid it if it's just for loader := NewLoaderFromFS(real.EmbeddedFS) and directly use the production embedded ones ?

I'll drop the whole thing

tiraboschi · 2026-08-20T13:29:41Z


 // Build constructs a RenderContext from the current HCO state
-func (b *RenderContextBuilder) Build(ctx context.Context, hco *unstructured.Unstructured) (*pkgcontext.RenderContext, error) {
+func (b *RenderContextBuilder) Build(ctx context.Context, hco *unstructured.Unstructured, kvFG []string) (*pkgcontext.RenderContext, error) {


I find the kvFG []string parameter on RenderContextBuilder.Build() a bit awkward. Build() already collects cluster state (nodes, topology, infra CRs), so KubeVirt feature gates fit better there than as a controller-owned input. Could we move getKubeVirtFGs into RenderContextBuilder (soft-fail to nil on error) and have updateConditionEvaluator read renderCtx.KubeVirtFeatureGates (so just r.updateConditionEvaluator(hco, renderCtx) instead of r.updateConditionEvaluator(hco, kvFGs, renderCtx)) ?

The CPUManager is not HCO's feature gate, but KubeVirt's. Added new condition type for KV FGs, and use it to replace the existing condition for kubelet-cpu-manager. Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

nunnatsa · 2026-08-24T05:35:38Z

/cherry-pick release-5.0

openshift-cherrypick-robot · 2026-08-24T05:35:47Z

@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-5.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nunnatsa · 2026-08-24T05:35:48Z

/cherry-pick release-4.23

openshift-cherrypick-robot · 2026-08-24T05:35:57Z

@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-4.23 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nunnatsa · 2026-08-24T06:13:53Z

/hold

trying to watch the KubeVirt CRD

openshift-ci Bot added the do-not-merge/work-in-progress label Aug 19, 2026

nunnatsa force-pushed the fix-CNV-93096 branch from 13e34c7 to 6d7fd25 Compare August 20, 2026 07:17

nunnatsa changed the title ~~WIP: add new condition type for KV FGs~~ CNV-93096: Fix wrong condition for the CPUManager feature gate Aug 20, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress label Aug 20, 2026

nunnatsa force-pushed the fix-CNV-93096 branch 2 times, most recently from 73e631d to 7b98f64 Compare August 20, 2026 10:02

nunnatsa force-pushed the fix-CNV-93096 branch from 7b98f64 to 78a8ae2 Compare August 20, 2026 10:08

nunnatsa force-pushed the fix-CNV-93096 branch from 78a8ae2 to 45823f8 Compare August 20, 2026 10:24

tiraboschi reviewed Aug 20, 2026

View reviewed changes

openshift-ci Bot added the needs-rebase label Aug 21, 2026

nunnatsa force-pushed the fix-CNV-93096 branch 4 times, most recently from 842852e to 1875258 Compare August 23, 2026 11:14

openshift-ci Bot removed the needs-rebase label Aug 23, 2026

Fix wrong conddition for the CPUManager feature gate

71b7158

The CPUManager is not HCO's feature gate, but KubeVirt's. Added new condition type for KV FGs, and use it to replace the existing condition for kubelet-cpu-manager. Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

nunnatsa force-pushed the fix-CNV-93096 branch from cbeb070 to 71b7158 Compare August 24, 2026 04:47

openshift-ci Bot added the do-not-merge/hold label Aug 24, 2026

		@@ -0,0 +1 @@
		../../../assets No newline at end of file

Uh oh!

Conversation

nunnatsa commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

openshift-ci Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nunnatsa commented Aug 24, 2026

Uh oh!

openshift-cherrypick-robot commented Aug 24, 2026

Uh oh!

nunnatsa commented Aug 24, 2026

Uh oh!

openshift-cherrypick-robot commented Aug 24, 2026

Uh oh!

nunnatsa commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nunnatsa commented Aug 19, 2026 •

edited

Loading