Skip to content

Catch up feature/mustang-ppl-integration with main: version bump to 3.7#5397

Open
ahkcs wants to merge 1 commit intoopensearch-project:feature/mustang-ppl-integrationfrom
ahkcs:pr/async-executor-update
Open

Catch up feature/mustang-ppl-integration with main: version bump to 3.7#5397
ahkcs wants to merge 1 commit intoopensearch-project:feature/mustang-ppl-integrationfrom
ahkcs:pr/async-executor-update

Conversation

@ahkcs
Copy link
Copy Markdown
Collaborator

@ahkcs ahkcs commented Apr 30, 2026

Summary

This is the first in a series of catch-up PRs to bring feature/mustang-ppl-integration up to date with main. It introduces the OpenSearch 3.7 version bump and the matching analytics-engine vendored JARs.

Subsequent PRs will continue merging the remaining commits from main (PPL bug fixes, new commands, etc.) into the feature branch incrementally so each chunk can be reviewed and CI-validated on its own.

Commits in this PR

Notes

  • CI is expected to surface failures; we will iterate on this branch (no force-push) to address them commit-by-commit.
  • The vendored JARs continue to use files() references so CI does not need publishToMavenLocal.

Test plan

  • ./gradlew build -x integTest passes locally
  • CI build passes
  • Spotless / format checks pass
  • Integration tests on the analytics-engine path still pass

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 1ceb5b7.

'Diff too large, requires skip by maintainers after manual review'


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@ahkcs ahkcs force-pushed the pr/async-executor-update branch from c4396f9 to 1ceb5b7 Compare April 30, 2026 20:11
@ahkcs ahkcs added maintenance Improves code quality, but not the product skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. skip-diff-reviewer Maintainer to skip code-diff-reviewer check, after reviewing issues in AI analysis. skip-changelog labels Apr 30, 2026
Catch up the analytics-engine feature branch with main as a single
squashed commit. The PR is opened against feature/mustang-ppl-integration;
when merged, the feature branch will reflect main's current state plus
the analytics-engine work already on it.

Squashed because the upstream main commits were authored by many
contributors with inconsistent DCO sign-offs (sign-offs missing or
formatted differently from author identity); DCO would otherwise reject
those upstream commits we cannot rewrite.

Resolved 16 merge conflicts:

Mechanical / append-both (9 files):
- CLAUDE.md, docs/user/ppl/functions/condition.md (took main)
- explain_streamstats_global{,_null_bucket}.yaml (took main, post-opensearch-project#5359)
- core/calcite/CalciteRelNodeVisitor.java, core/calcite/utils/PlanUtils.java
  (collation utility was hoisted from CalciteRelNodeVisitor.backtrackForCollation
  into PlanUtils.findInputCollation on main; took main)
- integ-test/calcite/CalciteNoPushdownIT.java (added CalciteMixedFieldTypeIT)
- ppl/antlr/OpenSearchPPLParser.g4 (added unionCommand)
- ppl/calcite/CalcitePPLStreamstatsTest.java (added testMultipleStreamstatsWithWindow)

Took main (api LanguageSpec evolution subsumes our side, 5 files):
- api/UnifiedQueryContext.java, UnifiedQueryPlanner.java
- api/UnifiedQueryPlannerSqlTest.java, UnifiedQueryTestBase.java
- plugin/SQLPlugin.java imports

Hand-merged (2 files):
- core/executor/QueryService.java: composed analytics-engine's
  CalciteClassLoaderHelper wrapper around main's StageErrorHandler
  stage-tracked phases; both improvements are orthogonal and apply.
- plugin/transport/TransportPPLQueryAction.java: kept both queryPlanExecutor
  parameter (analytics-engine wiring) and extensionsHolder parameter
  (main's engine extensions) since both are referenced in the constructor body.

Signed-off-by: Kai Huang <ahkcs@amazon.com>
@ahkcs ahkcs force-pushed the pr/async-executor-update branch from 1ceb5b7 to af831d3 Compare April 30, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improves code quality, but not the product skip-changelog skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. skip-diff-reviewer Maintainer to skip code-diff-reviewer check, after reviewing issues in AI analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant