Conversation
…prevent side-effect when removal, add removal and env pop to finally
…er cwd not touched
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
…vironment state and asserting it remains unchanged after upload attempt.
…ad safety and prevent unintended overrides. The new implementation inherits non-TWINE variables and injects reserver's credentials without mutating os.environ.
|
Hi Sadra @sadrasabouri, Best, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #129 +/- ##
==========================================
- Coverage 82.76% 77.66% -5.10%
==========================================
Files 5 6 +1
Lines 87 179 +92
Branches 10 31 +21
==========================================
+ Hits 72 139 +67
- Misses 6 24 +18
- Partials 9 16 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadrasabouri
left a comment
There was a problem hiding this comment.
Looks good overall. I only have a minor suggestion.
| "author_email": "test@test.com", | ||
| "url": "https://url.com", | ||
| "download_url": "https://download_url.com", | ||
| "source": "https://github.com/source", | ||
| "author_email": "reserver@openscilab.com", | ||
| "url": RESERVER_REPO_URL, | ||
| "download_url": RESERVER_REPO_URL, | ||
| "source": RESERVER_REPO_URL, |
There was a problem hiding this comment.
Is it actually better to have reserved information for the reserved package? I don't think so.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
In this PR, I apply internal clean-up and refactoring to better cover corner cases, improve robustness.
Any other comments?