Fix 6 issues in AssertJ recipe migrations#911
Merged
Conversation
Fixes the following compile errors from AssertJ best practices recipe: - Issue 1: assertThat(Object) ambiguity — cast to (Object) when actual type is java.lang.Object - Issue 2: UseAssertSame incorrectly converts null comparisons (x != null) to assertNotSame(x, null) - Issue 4: isCloseTo type mismatch when actual is integral but delta is floating-point - Issue 5: SimplifyChainedAssertJAssertion with Map<String, ?> wildcard types - Issue 7: hasSize(1L) converts long literal to int parameter - Issue 8: JUnitAssertThrowsToAssertExceptionType imports from wrong class (AssertionsForClassTypes) All 6 fixes are covered with new tests that verify the corrections work as expected. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 compile errors from the AssertJ best practices recipe when run on Apache SkyWalking:
assertThat(Object)ambiguity — add(Object)cast when actual type isjava.lang.ObjectUseAssertSameincorrectly converts null comparisons likeassertTrue(x != null)toassertNotSame(x, null)isCloseTotype mismatch when actual is integral but delta is floating-pointSimplifyChainedAssertJAssertionwithMap<String, ?>wildcard typeshasSize(1L)converts long literal to int parameterJUnitAssertThrowsToAssertExceptionTypeimports from wrong classTest Plan
🤖 Generated with Claude Code