Fix EnableLombokAnnotationProcessor to skip POMs where Lombok is already in effective POM#988
Closed
mcebanupgrade wants to merge 1 commit intoopenrewrite:mainfrom
Conversation
…ady in effective POM The previous implementation used `AddAnnotationProcessor` which only checked the current POM's own XML for an existing annotation processor configuration. This caused duplicate entries when the Lombok annotation processor was already configured in an ancestor POM outside the reactor (present in the effective POM but not in any in-reactor POM's own XML). The new `AddAnnotationProcessorToEffectivePom` recipe replicates the reactor-aware logic of `AddAnnotationProcessor` and adds an effective POM check: if the annotation processor is found in `ResolvedPom.getPlugins()/getPluginManagement()` (merged from all ancestors) but NOT in `Pom.getPlugins()/getPluginManagement()` (current POM's own XML), the POM is marked as already-configured and skipped in the visitor phase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Closing in favor of openrewrite/rewrite#6759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnableLombokAnnotationProcessorwas usingorg.openrewrite.maven.AddAnnotationProcessor, which only checks the current POM's own XML for an existing annotation processor configuration<path>entries when the Lombok annotation processor was already configured in an ancestor POM outside the reactor (present in the effective POM but not in any in-reactor POM's own XML)AddAnnotationProcessorToEffectivePomrecipe (local to this module) that checksResolvedPom.getPlugins()/getPluginManagement()(merged effective POM) vsPom.getPlugins()/getPluginManagement()(current POM's own XML) to detect inherited configuration and skip those POMsTest plan
AddAnnotationProcessorToEffectivePomTest.addToSingleModule— adds processor when not presentAddAnnotationProcessorToEffectivePomTest.doesNotDuplicateWhenAlreadyInOwnXml— no change when already in own XMLAddAnnotationProcessorToEffectivePomTest.addToParentPluginManagementInMultiModule— adds to parent'spluginManagementin multi-module projectAddAnnotationProcessorToEffectivePomTest.doesNotDuplicateWhenAlreadyInEffectivePomViaAncestor— key fix: 3-level hierarchy where grandparent has Lombok inpluginManagement, intermediate parent inherits it via effective POM but has no own XML config — intermediate parent is NOT modifiedUpgradeToJava25Test.doesNotDuplicateLombokAnnotationProcessorWhenAlreadyInParentPluginManagement— end-to-end: no duplicate<path>entry added when parent already has Lombok inpluginManagement🤖 Generated with Claude Code