Preserve Java 25 constructor extraction statements

[martinfrancois]

Suggested review order: 18 of 52 (Score: 6.5)
Review first: openrewrite/rewrite-static-analysis#976

What's changed?

Preserves the local declarations inserted before Java 25 explicit constructor invocations. The recipe now replaces the constructor arguments before inserting the Java 25 statements, allowing both transformations to use JavaTemplate without reparsing away the declarations.

What's your motivation?

Recipe: org.openrewrite.java.migrate.lang.ExtractExplicitConstructorInvocationArguments.

I found this by running org.openrewrite.java.migrate.lang.ExtractExplicitConstructorInvocationArguments from org.openrewrite.recipe:rewrite-migrate-java:3.40.0 on CodexAppServerClient.java in Symphony-Trello at a8013f27 with Java 25. I reproduced the same result with the latest released recipe artifact, org.openrewrite.recipe:rewrite-migrate-java:3.42.0. The recipe changed 11 files, and ./mvnw -DskipTests compile then reported undefined generated identifiers in production code.

Before

public CodexAppServerClient(ObjectMapper json, TrelloHandoffToolHandler trelloTools) {
    this(json, trelloTools, ApplicationClock.systemUtc());
}

Actual after the recipe

public CodexAppServerClient(ObjectMapper json, TrelloHandoffToolHandler trelloTools) {
    this(json, trelloTools, clock1);
}

Expected after the recipe

public CodexAppServerClient(ObjectMapper json, TrelloHandoffToolHandler trelloTools) {
    Clock clock1 = ApplicationClock.systemUtc();
    this(json, trelloTools, clock1);
}

The transformed constructor references clock1 without declaring it. The same mechanism generated other missing names, including workflowConfig1, healthChecker1, and repositorySources1, so the checkout no longer compiles.

Confirmed real-world execution

• Project: Symphony-Trello.
• Location: CodexAppServerClient.java at a8013f27.
• Discovery checkout: martinfrancois/symphony-trello@a8013f27.

Anything in particular you'd like reviewers to focus on?

Please review the transformation order. Replacing arguments first lets the pre-Java-25 parse shape remain valid for that template; inserting the Java 25 declarations last preserves them. The Java-25-only focused suite passes with both steps implemented through JavaTemplate.

Have you considered any alternatives or workarounds?

Constructing identifiers and variable declarations directly avoids the reparse, but OpenRewrite's template abstraction provides attributed nodes and preserves framework conventions when the operations are ordered safely.

Any additional context

Pre-existing tests changed: ExtractExplicitConstructorInvocationArgumentsTest.java.extractWithSourcePathWideningSupertype (updated).

• Target commit: martinfrancois/symphony-trello@a8013f27
• Discovery release: org.openrewrite.recipe:rewrite-migrate-java:3.40.0
• Latest verification release: org.openrewrite.recipe:rewrite-migrate-java:3.42.0
• Target verification: the baseline compiles; the transformed checkout reports missing generated variables in 11 files
• Focused tests: ExtractExplicitConstructorInvocationArgumentsTest, enabled only on Java 25 or later

This change was prepared with AI assistance. I reviewed the target execution evidence, implementation, tests, and contribution text.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've run ./gradlew build locally, and committed any resulting changes to recipes.csv
• I've formatted the lines I changed, without reformatting code I didn't touch