Add support for class-level Lombok @Getter and @Setter annotations - #1202
Open
Ouweshs28 wants to merge 1 commit into
Open
Add support for class-level Lombok @Getter and @Setter annotations#1202Ouweshs28 wants to merge 1 commit into
@Getter and @Setter annotations#1202Ouweshs28 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
UseLombokGetterOnTypeandUseLombokSetterOnTyperecipes to hoist default field-level Lombok accessor annotations to the class level.LombokBestPracticesafter the existing field-level accessor conversions.recipes.csv.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Please review the eligibility rules for static, final,
$-prefixed, configured, and mixed variable declarations. These fields retain their field-level annotations when Lombok type-level accessors would not generate equivalent methods.Anyone you would like to review specifically?
N/A
Have you considered any alternatives or workarounds?
I considered extending the existing field-level getter/setter recipes directly and using the external summarization recipes referenced in the issue. Separate composable recipes keep existing behavior stable while allowing
LombokBestPracticesto hoist annotations after field-level conversion.Any additional context
Checklist
./gradlew buildlocally, and committed any resulting changes torecipes.csv