Open
Conversation
Adds UpgradeApachePoi_5 which chains the 4.1 recipe and handles the POI 5.0 artifact renames (poi-ooxml-schemas -> poi-ooxml-lite, ooxml-schemas -> poi-ooxml-full), removes the merged ooxml-security dependency, and upgrades all POI artifacts to 5.x. Also copies the 4.1 recipe from the valencia worktree so the full 3.17 -> 4.1 -> 5.x chain is present and testable.
timtebeek
reviewed
Feb 17, 2026
| spec -> spec.after(pom -> { | ||
| Matcher version = Pattern.compile("5\\.\\d+\\.\\d+").matcher(pom); | ||
| assertThat(version.find()).describedAs("Expected 5.x in %s", pom).isTrue(); | ||
| String poiVersion = version.group(); |
Member
There was a problem hiding this comment.
This is an older style of asserting; these days we prefer spec.after(pom -> assertThat(pom).....your_assertions....actual())
Member
There was a problem hiding this comment.
AssertJ has quite some nice ways to assert what we're after without then having to recreate a text block, by using that actual().
timtebeek
approved these changes
Feb 17, 2026
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Recipe approved already; test assertions could use some polish.
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpgradeApachePoi_5recipe that chainsUpgradeApachePoi_4_1and handles POI 5.0 artifact renames (poi-ooxml-schemas→poi-ooxml-lite,ooxml-schemas→poi-ooxml-full), removes the mergedooxml-securitydependency, and upgrades all POI artifacts to 5.xChangeDependency,RemoveDependency,UpgradeDependencyVersion)Test plan
UpgradeApachePoi_5Testcases passSupporting documentation