bugfix: avoid truncating Lua context in filters#2512
Merged
Conversation
The request context was widened from uint16_t to uint32_t when phase flags grew beyond 16 bits, but the header and body filters continued saving it in a uint16_t old_context variable. Contexts above 0xffff were truncated while running a filter and restored as zero afterward. Use uint32_t for old_context to preserve the complete phase value.
zhuizhuhaomeng
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request context was widened from uint16_t to uint32_t when phase flags grew beyond 16 bits, but the header and body filters continued saving it in a uint16_t old_context variable.
Contexts above 0xffff were truncated while running a filter and restored as zero afterward. Use uint32_t for old_context to preserve the complete phase value.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.