Skip to content

tests: switch HTTP/3 curl to static-curl 8.20.0.#2509

Merged
zhuizhuhaomeng merged 2 commits into
openresty:masterfrom
tzssangglass:up-curl-in-ci
Jun 28, 2026
Merged

tests: switch HTTP/3 curl to static-curl 8.20.0.#2509
zhuizhuhaomeng merged 2 commits into
openresty:masterfrom
tzssangglass:up-curl-in-ci

Conversation

@tzssangglass

Copy link
Copy Markdown
Contributor

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

@tzssangglass tzssangglass changed the title ci: switch HTTP/3 curl to static-curl 8.20.0. tests: switch HTTP/3 curl to static-curl 8.20.0. Jun 17, 2026
CI switched to curl 8.20.0 (static-curl 8.20.0). Several curl changes
since 8.3.0 altered the stderr messages our tests match against, so the
affected `--- curl_error` expectations need updating.

The changes map to three upstream curl commits:

* http/3: add description for known server error codes (f6e8531c03ed,
  8.19.0) appends the error code and its name to the HTTP/3 stream
  reset message:
    "HTTP/3 stream 0 reset by server"
    -> "HTTP/3 stream 0 reset by server (error 0x102 INTERNAL_ERROR)"
  -> t/005-exit.t

* h2+h3: align stream close handling (0f042efcb1, 8.19.0) rewrites the
  HTTP/2 stream reset message and aligns it with HTTP/3:
    "HTTP/2 stream 1 was not closed cleanly" / "was reset"
    -> "HTTP/2 stream 1 reset by server (error 0x2 INTERNAL_ERROR)"
  (it also changed the HTTP/3 path that emits
   "ngtcp2_conn_writev_stream returned error: ERR_CLOSING")
  -> t/033-ctx.t, t/041-header-filter.t, t/091-coroutine.t

* ngtcp2: check error code on connect failure (115fe808f2, 8.17.0) makes
  a QUIC handshake aborted by the server a permanent connect failure
  (CURLE_COULDNT_CONNECT, exit 7) instead of retrying until a timeout.
  The test (which deliberately fails the handshake via ngx.exit(500) in
  ssl_certificate_by_lua*) now sees:
    "curl: (28) Connection time-out"
    -> "Failed to connect to ... port ... after N ms: Could not connect
       to server"
  -> t/166-ssl-client-hello.t
@mergify

mergify Bot commented Jun 28, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@zhuizhuhaomeng zhuizhuhaomeng merged commit 81d7022 into openresty:master Jun 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants