tests: switch HTTP/3 curl to static-curl 8.20.0.#2509
Merged
Conversation
CI switched to curl 8.20.0 (static-curl 8.20.0). Several curl changes
since 8.3.0 altered the stderr messages our tests match against, so the
affected `--- curl_error` expectations need updating.
The changes map to three upstream curl commits:
* http/3: add description for known server error codes (f6e8531c03ed,
8.19.0) appends the error code and its name to the HTTP/3 stream
reset message:
"HTTP/3 stream 0 reset by server"
-> "HTTP/3 stream 0 reset by server (error 0x102 INTERNAL_ERROR)"
-> t/005-exit.t
* h2+h3: align stream close handling (0f042efcb1, 8.19.0) rewrites the
HTTP/2 stream reset message and aligns it with HTTP/3:
"HTTP/2 stream 1 was not closed cleanly" / "was reset"
-> "HTTP/2 stream 1 reset by server (error 0x2 INTERNAL_ERROR)"
(it also changed the HTTP/3 path that emits
"ngtcp2_conn_writev_stream returned error: ERR_CLOSING")
-> t/033-ctx.t, t/041-header-filter.t, t/091-coroutine.t
* ngtcp2: check error code on connect failure (115fe808f2, 8.17.0) makes
a QUIC handshake aborted by the server a permanent connect failure
(CURLE_COULDNT_CONNECT, exit 7) instead of retrying until a timeout.
The test (which deliberately fails the handshake via ngx.exit(500) in
ssl_certificate_by_lua*) now sees:
"curl: (28) Connection time-out"
-> "Failed to connect to ... port ... after N ms: Could not connect
to server"
-> t/166-ssl-client-hello.t
7edc6d0 to
d9403d4
Compare
zhuizhuhaomeng
approved these changes
Jun 28, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.