Repository navigation
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Ekhorn
force-pushed
the
enhancement/migrate-json-forms-to-vaadin
branch
2 times, most recently
from
October 2, 2026 11:29
904bfe0 to
b2b8865
Compare
Ekhorn
commented
Oct 2, 2026
Ekhorn
marked this pull request as ready for review
October 2, 2026 12:00
Ekhorn
force-pushed
the
enhancement/migrate-json-forms-to-vaadin
branch
from
October 2, 2026 14:10
b2b8865 to
36e47f3
Compare
Object-typed schema properties such as a websocket subscription body map to InputType.JSON, which was missing from the or-vaadin-input templates and so fell back to or-mwc-input. Register it along with JSON_OBJECT and marshal the value, since a JSON field holds text rather than its value.
Render the add item and add parameter panes as cards against the tinted dialog background instead of splitting them with a border, and hold the body at the same 600px the add asset dialog uses so a short list still fills the dialog. The JSON editor matches.
Ekhorn
force-pushed
the
enhancement/migrate-json-forms-to-vaadin
branch
from
October 2, 2026 14:18
ee1031a to
1d776e2
Compare
MartinaeyNL
requested changes
Oct 5, 2026
Ekhorn
force-pushed
the
enhancement/migrate-json-forms-to-vaadin
branch
from
October 7, 2026 07:58
a02a429 to
9beabd9
Compare
2 of 4 tasks
Ekhorn
force-pushed
the
enhancement/migrate-json-forms-to-vaadin
branch
from
October 7, 2026 16:42
8f7c42c to
886e3ad
Compare
MartinaeyNL
reviewed
Oct 15, 2026
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist