Fix radar pair weighting being referenced by cur_array #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 32 32
Lines 5169 5169
=======================================
Hits 3568 3568
Misses 1601 1601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Your PR should not have changed the test coverage at all...so that's an odd error there. Otherwise it looks like tests are passing. I have an issue open for the low test coverage (#140) that the community and I are welcome to work on to improve the unit testing suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is related to discussion in https://openradar.discourse.group/t/weighting-between-radars/661/2
Tested scipy_engine and showed reasonable coverage after the fix. Changed also the tensorflow part, but do not have required hardware to test tensorflow part.
weight_bg may have similar problem in view of similar structure. However, I have not used that part, and hence not in a position to comment. Also, if bg wind is supplied by users, normally the weighting will also be supplied. Therefore, the weight_bg part is left unchanged.